Merge pull request #46 from fingerprintjs/fix/freeze-flutter-version

Use latest flutter version for all workflows
fingerprintjs · Jun 30, 2023 · 6dc5b84 · 6dc5b84
2 parents e27500b + 87f1675
commit 6dc5b84
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -15,7 +15,7 @@ jobs:
       - name: Install and set Flutter version
         uses: subosito/flutter-action@0c3f14223a08fa950c8a4c00bcfb834e65744135
         with:
-          flutter-version: '3.3.8'
+          channel: 'stable'
       - name: Restore packages
         run: flutter pub get
       - name: Create .env.local

diff --git a/test/fpjs_pro_plugin_test.dart b/test/fpjs_pro_plugin_test.dart
@@ -34,15 +34,18 @@ void main() {
 
   group('getVisitorId', () {
     setUp(() {
-      channel.setMockMethodCallHandler((MethodCall methodCall) async {
+      TestDefaultBinaryMessengerBinding.instance.defaultBinaryMessenger
+          .setMockMethodCallHandler(channel, (MethodCall methodCall) async {
         if (methodCall.method == 'getVisitorId') {
           return testVisitorId;
         }
+        return null;
       });
     });
 
     tearDown(() {
-      channel.setMockMethodCallHandler(null);
+      TestDefaultBinaryMessengerBinding.instance.defaultBinaryMessenger
+          .setMockMethodCallHandler(channel, null);
     });
 
     test('should return visitor id when called without tags', () async {
@@ -67,15 +70,18 @@ void main() {
 
   group('getVisitorData', () {
     setUp(() {
-      channel.setMockMethodCallHandler((MethodCall methodCall) async {
+      TestDefaultBinaryMessengerBinding.instance.defaultBinaryMessenger
+          .setMockMethodCallHandler(channel, (MethodCall methodCall) async {
         if (methodCall.method == 'getVisitorData') {
           return [requestId, confidence, extendedResultAsJsonString];
         }
+        return null;
       });
     });
 
     tearDown(() {
-      channel.setMockMethodCallHandler(null);
+      TestDefaultBinaryMessengerBinding.instance.defaultBinaryMessenger
+          .setMockMethodCallHandler(channel, null);
     });
 
     test('should return visitor id when called without tags', () async {