Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encapsulate the fonts entropy source #635

Merged
merged 2 commits into from
Mar 26, 2021
Merged

Conversation

Finesse
Copy link
Member

@Finesse Finesse commented Mar 26, 2021

Resolves #592
Resolves #628

Makes the source be more stable by protecting it from page styles, but increases the execution time by about 50%.

It protects the component from page styles effects, but increases the execution time by about 50%
@Finesse Finesse merged commit e7f3498 into master Mar 26, 2021
@Finesse Finesse deleted the feature/optimize-fonts branch March 26, 2021 11:44
@Finesse Finesse changed the title Incapsulate the fonts entropy source Encapsulate the fonts entropy source Mar 26, 2021
Finesse added a commit that referenced this pull request Mar 26, 2021
Squashed commit of the following:

commit 85a95bd
Author: Surgie Finesse <finesserus@gmail.com>
Date:   Fri Mar 26 18:22:31 2021 +1000

    Run the fonts source in an iframe

    It protects the component from page styles effects, but increases the execution time by about 50%

commit b371c13
Author: Surgie Finesse <finesserus@gmail.com>
Date:   Fri Mar 26 17:02:05 2021 +1000

    Make the fonts component be more style independent and eliminate excess layout operations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fonts source changes the look of the page Font component changes due to @font-face
1 participant