Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use latest versions of safari for OSX tests #895

Closed
wants to merge 1 commit into from

Conversation

fpkamp
Copy link
Contributor

@fpkamp fpkamp commented Apr 21, 2023

No description provided.

@fpkamp fpkamp requested a review from bayotop April 21, 2023 14:29
@fpkamp fpkamp changed the title use latest versions of Safari for testing use latest versions of safari for OSX tests Apr 21, 2023
OSX13_Safari16: { platform: 'OS X', osVersion: 'Ventura', browserName: 'Safari', browserVersion: '16', useHttps: false },
'OSX10.14_Safari12': { platform: 'OS X', osVersion: 'Mojave', browserName: 'Safari', browserVersion: 'latest', useHttps: true },
OSX12_Safari15: { platform: 'OS X', osVersion: 'Monterey', browserName: 'Safari', browserVersion: 'latest', useHttps: false },
OSX13_Safari16: { platform: 'OS X', osVersion: 'Ventura', browserName: 'Safari', browserVersion: 'latest', useHttps: false },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to target specific Safari versions, not macOS versions. Safari major version isn't bound to a macOS version (for example, I have Safari 16.4 on macOS 11 which was shipped with Safari 14 originally). It doesn't seem to be a case on BrowserStack, but still this is a concern to me.

What do you think if we use specific major versions for old versions of macOS, and latest for the latest version of macOS?

As I can see in BrowserStack configurator, there is only 1 Safari version for each macOS version. Did you check that using latest instead of 16 makes a difference?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, it doesn't and you always get served the newest one available for the requested OS X version (for Monterey that would be 15.6 as 16 is not available for Monterey), so I think we don't need it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, it doesn't

Do you mean that using latest instead of a number makes no difference? If so, let's close the PRs.

@fpkamp fpkamp closed this May 4, 2023
@fpkamp fpkamp deleted the feature/use-latest-safari branch May 4, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants