-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: non-ASCII support and optimization in murmurhash3
#931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finesse
reviewed
Aug 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please list shortly the optimizations that you applied in the PR description
Done |
Finesse
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added proper support for non-ASCII symbols for
murmurhash3_128_x64
. Previous implementation wasn't compatible with implementation in other languages (e.g. Golang, C++) for symbols with charcodes outside of0 - 0xff
range. Also it was limited in terms of uniqueness, e.g.hash('Hello, world, hi')
was equal tohash('ňťŬŬůĬĠŷůŲŬŤĬĠŨũ')
.Current new implementation are free of these issues
Also I refactored internal functions to achieve minimal minimal memory allocations and reduce GC load, it gained performance boost:
Optimizations:
int64
values (int32 tuples) are passed to mutable functions, and the result is written back to the valueBenchmark (sorry for the minified code in the benchmark,
jsbench
allows to save suite only if fields are below 2048 symbols, so I tried to make it more compact)JSBench screenshots
Webkit
Chrome
Firefox
Other implementations that I've tried:
int32
tuples feat:murmur3hash
BigInt implementation #933murmur3hash
with iteration through code points #936