feat: Increase accuracy of Chromium Android detection #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bayotop
reviewed
Nov 6, 2023
src/utils/browser.ts
Outdated
| ]) >= 2 | ||
| ) | ||
| if (isItChromium) { | ||
| return countTruthy([!('SharedWorker' in w), isAndroidNotificationError(), 'sinkId' in new window.Audio()]) >= 2 |
There was a problem hiding this comment.
This should be !('sinkId' in new window.Audio()), because it's not available on Android.
There was a problem hiding this comment.
Good catch, thanks!
|
Please download some old Chrome and Firefox version APKs and check the detector function on an Android Emulator or a real device. One good APK source is https://4pda.to/forum/. |
Tested on Firefox 67 and Chrome 91, works fine |
Finesse
approved these changes
Nov 8, 2023
bayotop
approved these changes
Nov 9, 2023
|
@dj-stormtrooper Could you please update the Android detection function in BotD too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.