fix: Replace android notification detector #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finesse
reviewed
Nov 14, 2023
Finesse
previously approved these changes
Nov 14, 2023
bayotop
previously approved these changes
Nov 14, 2023
|
Please bump the version also |
Cancel, let's publish tomorrow morning |
dj-stormtrooper
dismissed stale reviews from bayotop and Finesse
via
dde0d4c
Finesse
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #968
Detector based on
Notificationconstuctor was replaced withontypechangecheck.Though this particular method returns
trueon Chromebook with latest Chrome browser, the other detectors returnfalsewhich makes the total result stable