fix: WebGL console warning in Chrome 121 and Safari 17.4 #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finesse
commented
Jan 26, 2024
src/sources/webgl.ts
Outdated
| @@ -132,7 +133,8 @@ export function getWebGlExtensions({ cache }: Options): WebGlExtensionsPayload | | |||
| // Extension parameters | |||
| if (extensions) { | |||
| for (const name of extensions) { | |||
| if (name === rendererInfoExtensionName && shouldAvoidDebugRendererInfo()) { | |||
| // The "polygon mode" extension causes a console warning in Chromium and WebKit | |||
There was a problem hiding this comment.
Firefox emits no warning because it doesn't support WEBGL_polygon_mode yet (even the nightly 124 version). So I don't turn it off in Firefox until we know how it behaves.
Because Gecko doesn't support the extension yet, so we don't know whether it will emit a warning
Finesse
force-pushed
the
fix/webgl-console-warning
branch
from
878d111
to
0272a60
Compare
dj-stormtrooper
approved these changes
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This remove an unwanted console message arising in:
webgl.ts:139 WebGL: this extension has very low support on mobile devices; do not rely on it for rendering effects: WEBGL_polygon_modeWebGL: non-portable extension enabled: WEBGL_polygon_modeThe PR disables the
WEBGL_polygon_modeextension, but this is not a fingerprint-breaking change, because the extension didn't exist in the previous versions. Though the browser updates change the fingerprint because of other changes to WebGL.