Add Localization to the sample #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingers10
reviewed
Sep 6, 2020
fingers10
reviewed
Sep 6, 2020
fingers10
requested changes
Sep 6, 2020
There was a problem hiding this comment.
Hey @jptoros ,
Many thanks for the PR. I have recommended/suggested few changes. Please can you review and fix it so that I can merge your changes. Once the changes are merged, the repository will automatically display you as an contributor.
Cheers,
@fingers10
fingers10
approved these changes
Sep 12, 2020
|
@jptoros Thanks for the PR. Merged to master. Your name will appear in contributors list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did add a small menu to choose between English and French. I did translate all the default table. The edit modal is not translated but it the same logic.
Needed to move the js into the view itselft to be able to use the Localize tag. In a real app, the user should use a ViewComponent.