Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://jira.fingo.info/projects/IJ/issues/IJ-301 Upgrade some of the libraries #173

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Arsenicro
Copy link
Member

These changes may require removing the old node-modules folder and running npm install again.

  • Upgrade react-scripts - use default imports instead of named ones to import scss files (the new version of react-scripts does not support it)
  • Upgrade react-bootstrap - for some reason new version does not see styles while testing, so instead of checking if the dropdown is visible, we will check if it has the class show.
  • Upgrade react-notification - the way we should import it is different now
  • Remove unused redux and uuid

The rest of the upgraded libraries did not require any changes.

With these changes, we have only 6 libraries without the newest version.

  • axios, because version 1.0 does not seem stable yet
  • react and react-dom because of react-month-picker (and maybe something more, we have to check it)
    * react-notifications-component and @testing-library/react - because they require react 18
  • react-router-dom - because the new react-router is somewhat different, there will be more changes that need to be done to upgrade it

@Arsenicro Arsenicro marked this pull request as ready for review October 24, 2022 08:07
@DaDudek
Copy link
Contributor

DaDudek commented Oct 28, 2022

approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants