Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strict kex #104

Closed
wants to merge 1 commit into from
Closed

Conversation

darses
Copy link

@darses darses commented Feb 21, 2024

This PR adds both client and server extensions to the specification page and all implementations that support these extensions.

I added both client and server extensions separately, even though I could not find an implementation that includes either one. So either both are supported, or none.

I did not list implementations with support in unreleased versions, such as Dropbear and libssh2.

The information about support is gathered primarily from the liste patches on the Terrapin website. I added a couple of other implementations based on the changelog referenced from the existing spec file.

Finally I noticed that some implementations did not contain an extensions variable in the spec file. As a result a couple of implementations now list several other extensions as 'no/unsupported'. Note that I did not check support for other extensions, so please let me know if this is an issue.

This closes #103

@darses darses marked this pull request as ready for review April 13, 2024 13:11
@norrisjeremy
Copy link
Contributor

kex-strict-c-v00@openssh.com & kex-strict-s-v00@openssh.com shouldn't be placed under extension but rather kex.

Similar to ext-info-c & ext-info-s, they are advertised by both client & server side along side kex algorithms.

The extension section is intended to document SSH_MSG_EXT_INFO extensions (see RFC-8308).

@norrisjeremy
Copy link
Contributor

See #105 that correctly documents this in kex for OpenSSH & JSch.

@fingolfin fingolfin closed this Jul 13, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the strict key exchange extension
3 participants