Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scribus upgrade #125

Merged
merged 6 commits into from Jan 8, 2021
Merged

Scribus upgrade #125

merged 6 commits into from Jan 8, 2021

Conversation

nieder
Copy link
Member

@nieder nieder commented Apr 7, 2018

Updates scribus to latest 1.4.6
Fixes to build as x86_64 so that it can link to our libraries as expected

@nieder
Copy link
Member Author

nieder commented Apr 7, 2018

Emailed Martin Costabel so he knows about it and we can get his github handle.

@dmacks
Copy link
Member

dmacks commented Dec 11, 2019

It's been 1.5 years...time to get'erdone if Martin is AWOL? Upstream is now up to 1.4.8 and fink now has boost1.68. Is hardcoded /opt/X11 correct for x11 on all currently-supported distros or should CompileScript determine it on-the-fly?

@nieder nieder requested a review from costabel February 29, 2020 13:05
@nieder
Copy link
Member Author

nieder commented Feb 29, 2020

/opt/X11 is correct from 10.9 and up. Could use buildenv-modules, but not necessary when it's just a single settings that's currently fixed.

@dmacks dmacks mentioned this pull request Jan 5, 2021
@dmacks
Copy link
Member

dmacks commented Jan 6, 2021

Confirmed -x11 buildable on 10.13, so we should get this in soon (existing has deps on a boost that doesn't even exist in most dists). I instrumented the build with:

       -DCMAKE_CXX_FLAGS="-MD" \
       -DCMAKE_C_FLAGS="-MD" \

and fink-package-precedence and otool-L on the binaries indicate that expat1, fontconfig2, and glib2 are not needed, but that libhunspell1.6-dev/-shlibs is a missing dep.

Edit: fontconfig2-shlibs is not linked but the -dev is used at build-time

Given this thing links fink's python27, should it be using the -python27 variant of boost rather than -systempython?

@dmacks
Copy link
Member

dmacks commented Jan 7, 2021

-aqua variant is good too (same dep comments as for -x11). However, regarding boost... it's only build-time not runtime, so I don't know if it matters what python the boost claims to match. The -aqua package does not use appear to use fink's python27, so using boost -systempython keeps fink's python out of the whole dep-tree. I really don't care, just am tired of seeing dep-tree holes and FTBFS.

@nieder nieder added the new upstream Package has an updated upstream version label Jan 7, 2021
@dmacks
Copy link
Member

dmacks commented Jan 7, 2021

lgtm

@costabel
Copy link
Contributor

costabel commented Jan 7, 2021 via email

@nieder
Copy link
Member Author

nieder commented Jan 8, 2021

I'll go ahead and unmaintain you from both packages.

@nieder nieder merged commit d7cff04 into fink:master Jan 8, 2021
@nieder nieder deleted the scribus-upgrade branch January 8, 2021 10:44
@costabel
Copy link
Contributor

costabel commented Jan 8, 2021 via email

@dmacks dmacks mentioned this pull request Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new upstream Package has an updated upstream version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants