ncurses-6.0 from tracker #29

nieder · 2018-01-01T21:45:01Z

This is a transfer of @jwhowarth's update for ncurses-6 and libncurseswfrom the tracker: https://sourceforge.net/p/fink/package-submissions/4803/ and https://sourceforge.net/p/fink/package-submissions/4804/

Things to figure out:

the submission uses a new libN, but ./configure has a --with-abi-version flag that can be used to set the libN back to 5 as in our current package. Do we want a new libN for ncurses?
if we do keep the new libN=6, does the ncurses-%v=6 package get to keep its Essential: true field?

https://sourceforge.net/p/fink/package-submissions/4803/ https://sourceforge.net/p/fink/package-submissions/4804/

dmacks · 2018-01-01T22:03:30Z

I see --without-pkg-config, and agree with its reasoning:

Disable pkg-config so we don't need to make it Essential:true
(as dependency of Essential:true ncurses). gen-pkgconfig says
the *-config scripts are the recommended way anyway.

But I wonder if there is a way to get the .pc installed even without detecting the presence of /sw/bin/pkg-config. It looks like the only reason to detect that is to decide if to generate and install the .pc file (and simply short-circuits some otherwise-usable logic for determining the installation path).

dmacks · 2018-01-01T22:05:44Z

Switching up to a new libversion (== new package-name for the -dev) would allow us to stop dragging along the static libs and fix detection/linking/runtime-dependencies when reverse-builddepends are migrated. If we keep the same -dev package-name, we should keep the .a out of inertia because we don't know how many reverse-builddepends actually care about it.

dmacks · 2018-01-01T22:10:03Z

10.9-libcxx/stable/main/finkinfo/base/libncurses6-shlibs.info

+ BuildDependsOnly: true
+ Conflicts: ncurses-dev, libncurses5-64bit, libncurses5
+ Replaces: ncurses-dev, ncurses (<= 5.3-20031018-2), libncurses5-64bit, ncurses (<= 5.7-20100227-1), libncurses5
+ Provides: libncurses6-dev


There was a libncurses5:Provides:libncurses5-dev since long ago; do we really need this cargo-culting if we are starting with a new libversion? "foo/foo-shlibs" is a well-established pattern for library package-sets.

There are nine packages with BDep:libncurses5-dev, which seems like low fruit for a cleanup task (no rev-up required, etc.)

dmacks · 2018-01-01T22:18:02Z

The .info filenames are getting chaotic. Especially if we switch to a new libversion, we should standardize on *-shlibs.info to make it easier to compare the libversions to each other (harder if the parent vs splitoff switch places).

dmacks · 2018-01-01T22:25:52Z

libncursesw6/libncursesw6-shlibs are not essential, so the DescPackaging notes are not correct. They are explicitly tagged Essential:false IIRC because they originally were Essential:true (maybe even part of the main package instead of separate ...w5... set?) and this was the only way to move towards allowing them to be uninstalled. If we're switching to a new libversion, can probably scrap this tag altogether since I think it only boolean (false==undef) not tri-state (true/false/undef) in fink core code.

beren12 · 2018-01-01T22:41:58Z

I chose to follow the Debian library naming convention when we did splitoffs… since the library is the main package it's the libfoo name, with -dev and -bin splitoffs. Personally I prefer that for library packages still.

dmacks · 2018-01-01T22:47:00Z

But "the library is the main package it's the libfoo name, with -dev and -bin splitoffs." does not match current layout practice or packging policy. I think libfoo (or foo) as the runtime libraries (rather than libfoo-shlibs or foo-shlibs) is unique for libiconv. For the record, I'm agnostic about libfoo/libfoo-shlibs vs libfoo-dev/libfoo-shlibs.

TheSin- · 2018-01-01T22:49:29Z

I agree with @beren12 I prefer the Debian scheme as well, it makes porting much easier, specially since I ported all of debhelper.

dmacks · 2018-01-01T22:50:22Z

Switching to a new libversion would also allow us to unbury the library files (use %p/lib instead of %p/lib/ncurses). Presumably we did that in order to avoid masking apple's libraries, but then we moved the main links to %p/lib anyway and use fink-package-precedence enforce use of fink's.

dmacks · 2018-01-01T22:59:01Z

Regarding --with-abi-version, is the new version actually ABI-compatible? There are about 135 reverse-depends, some of which look like no-longer-relevant inherited deps and many of which have complex versioning dating back to the 10.4-transitional era. The migration would be a chance to clean up some uselessness.

nieder · 2018-01-02T03:32:00Z

I managed to get the following in ncurses-5 with pkg-config uninstalled.

checking if you want to use pkg-config... no
checking if we should install .pc files for none... yes
... and inside ncurses.deb ...
drwxr-xr-x root/admin        0 2018-01-01 20:37 ./sw/lib/pkgconfig/
-rw-r--r-- root/admin      262 2018-01-01 20:37 ./sw/lib/pkgconfig/form.pc
-rw-r--r-- root/admin      266 2018-01-01 20:37 ./sw/lib/pkgconfig/form_g.pc
-rw-r--r-- root/admin      262 2018-01-01 20:37 ./sw/lib/pkgconfig/menu.pc
-rw-r--r-- root/admin      266 2018-01-01 20:37 ./sw/lib/pkgconfig/menu_g.pc
-rw-r--r-- root/admin      288 2018-01-01 20:37 ./sw/lib/pkgconfig/ncurses++.pc
-rw-r--r-- root/admin      254 2018-01-01 20:37 ./sw/lib/pkgconfig/ncurses.pc
-rw-r--r-- root/admin      272 2018-01-01 20:37 ./sw/lib/pkgconfig/ncurses_g.pc
-rw-r--r-- root/admin      264 2018-01-01 20:37 ./sw/lib/pkgconfig/panel.pc
-rw-r--r-- root/admin      268 2018-01-01 20:37 ./sw/lib/pkgconfig/panel_g.pc

$ cat ncurses.pc 
prefix=/sw
exec_prefix=${prefix}
libdir=/sw/lib/ncurses
includedir=${prefix}/include
major_version=5
version=5.9.20110507

Name: ncurses
Description: ncurses 5.9 library
Version: ${version}
Requires: 
Libs: -L${libdir} -lncurses 
Cflags: -I${includedir}

The .pc file generation doesn't need to have %p/lib/pkgconfig exist during buildtime either. With ncurses-6, I can build the .pc files, but not yet install them properly.

I have no idea if setting --with-abi-version=5 with ncurses-6 is compatible with ncurses-5. I'm trusting upstream did the right thing. But if there's any doubt, then clean break to abi=6 (default) would make sense.

My only tests so far were to make sure v6 of libncurses and libncursesw built as is. I wanted to have finalized decisions on our various options before I went out to really modify the build.

new libN.
rename headers package to libncurses6-dev?
standardize all 4 packages as FOO-shlibs.info (libncurses{,w}{5,6}-shlibs.info)?
get rid of carryover stuff from libncurses5
-- get rid of static libs
-- unbury libraries
-- kill Provides: in headers pkg
generate .pc files w/out needing pkg-config

dmacks · 2018-01-02T04:19:19Z

For ncurses6:

  --with-pkg-config=/usr/bin/true \
  --with-pkg-config-libdir=%p/lib/pkgconfig \
  --enable-pc-files \

gets me .pc created and installed, both with and without pkg-config itself installed:

checking if you want to use pkg-config... /usr/bin/true
checking for /usr/bin/true library directory... /sw/lib/pkgconfig
checking if we should install .pc files for /usr/bin/true... yes
checking for suffix to add to pc-files... none

Weird but functional spaghetti. Need to add lib/pkgconfig to the Files: for libncurses6 (to accompany the headers, etc.)

dmacks · 2018-01-02T05:02:28Z

Thanks for the ncurses5 example. Turns out it works for ncurses6 also:

  --enable-pc-files \
[...]
  PKG_CONFIG=%p/bin/pkg-config \
  PKG_CONFIG_LIBDIR=%p/lib/pkgconfig

and doesn't even need the "Don't test for presence of PKG_CONFIG_LIBDIR" PatchScript (ncurses6 doesn't appear to have anything comparable in its configure scripts).

danielj7 · 2018-01-06T01:56:36Z

I would recommend not having a separate libncursesw6 package. There's no good reason to keep carrying both around. Just build libncurses6 with --enable-widec and add --disable-lib-suffixes to cause it to build without the 'w' suffix. That's what the system ncurses does. I'd also recommend --with-pthread while we're doing a new libN.

Also adding cf_cv_typeof_chtype=long to ConfigureParams hasn't been necessary since 32 bit days.

The big ABI difference between 5 and 6 is that many types became opaque and you need to use accessor functions instead of accessing struct fields directly.

dmacks · 2018-01-06T20:24:36Z

While looking at whether a new libversion package's "ncurses" package should retain Essential:true, I noticed that the API manpages are in ncurses rather than the headers package. TODO: fix that.

But ncurses in the new .info should retain Essential:true. Otherwise it is no longer essential and might not get updated (sync problem with the new lib?). Or if it got updated it would no longer be essential and then could get removed altogether. The question is: what is that package's role? It looks like it's both user-level utility programs and runtime terminfo data for the library? Maybe the terminfo should be sent to a separate package (maybe even a separate .info?) that can be Essential and have the libs Depends on it, and then ncurses utility programs could be a no-longer-Essential splitoff of the libs' .info.

nieder · 2018-01-06T21:32:29Z

FWIW, Ubuntu sends their /sw/share/terminfo/ to a different package ncurses-term. Only ncurses-base and ncurses-bin are essential. ncurses-base has a subset of basic terminfo files. ncurses-bin are the executables. For them, they link to libtinfo.so.5. For us, they link to libncurses.5.dylib.

The libtinfo library is a subset of the libncurses library that can be built with the --with-termlib flag. We don't do this split.

When building the ncurses library, organize this as two parts:  the
	curses library (libncurses) and the low-level terminfo library
	(libtinfo).  This is done to accommodate applications that use only
	the latter.  The terminfo library is about half the size of the total.

nieder · 2018-01-06T21:39:02Z

beren12 · 2018-01-07T02:59:40Z

On Jan 6, 2018, at 4:39 PM, nieder ***@***.***> wrote: TODO: • bump ABI to 6 • drop libncursesw6 and instead put —enable-widec in libncurses6 (plus extra flags as @danielj7 suggested) • unbury libraries and put them back into %p/lib • kill static .a • standardize how to generate the .pc files across new and existing .info to make file comparisons easier • drop cf_cv_typeof_chtype flag • move man3 files from ncurses to libncurses{5,6} • retain Essential: true for ncurses and libncurses6-shlibs • offload terminfo files to a new splitoff • decide on naming for new libN=6 headers: libncurses6 vs libncurses6-dev. libncurses6-dev would allow dropping the Provides field. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

I still object to the name libncurses6-shlibs, with TheSin. It didn’t used to be policy to require it this way, and we should consider adding allowances in the guide for library packages being libfoo, libfoo-bin and libfoo-dev. It just makes sense and it how everyone else names library packages

nieder · 2018-01-07T04:00:17Z

I'm agnostic on requiring -dev for the headers SplitOff, and since the current package is ncurses/libncurses5-shlibs/libncurses, I would lean towards keeping the name pattern this way with libN=6 to simplify transitioning packages to it.

This current SplitOff name pattern is ancient for ncurses and dates back to the 10.2-gcc3.3 period.
https://github.com/fink/fink-distributions/blob/master/10.2-gcc3.3/stable/main/finkinfo/base/ncurses.info

The TODO list above is not final. It's the current state (to my eye) of the discussion. If something changes, the TODO list will be edited.

nieder · 2018-01-20T14:00:11Z

Apart from the SplitOff naming issue, are there other new issues to address or other things in the TODO list are still under debate?

dmacks · 2018-01-20T21:50:44Z

What is it about "ncurses" that makes it Essential, the bin/* or the share/{tabset,terminfo}? I had assumed it was the share/ stuff, as "/sw/share/terminfo" is accessed by the .dylib, rather than some command-line programs that themselves link to the libraries. By keeping ncurses Essential, we assure it is installed, so we avoid a circular dependency of binary->library->datafile where binary and datafile are in the same package separate from library. Assuming so, I would think only the package with the datafiles would need to retain the Essential flag. Debian has a similar binary/library/datafile division and calls their datafiles package "ncurses-term" or "ncurses-base".

dmrrsn-fink · 2018-01-20T22:25:59Z

Back in the day, this had to do with bootstrapping IIRC.

…

On Jan 20, 2018, at 1:50 PM, Daniel Macks ***@***.***> wrote: What is it about "ncurses" that makes it Essential, the bin/* or the share/{tabset,terminfo}? I had assumed it was the share/ stuff, as "/sw/share/terminfo" is accessed by the .dylib, rather than some command-line programs that themselves link to the libraries. By keeping ncurses Essential, we assure it is installed, so we avoid a circular dependency of binary->library->datafile where binary and datafile are in the same package separate from library. Assuming so, I would think only the package with the datafiles would need to retain the Essential flag. Debian has a similar binary/library/datafile division and calls their datafiles package "ncurses-term" or "ncurses-base". — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

…te library. Kill static libraries. Remove typeof flag that's not needed in 64bit systems.

Since this is a new libN, there's no reason to hide them and we prefer to use Fink provided libs over system-libs now.

nieder · 2018-03-26T10:42:24Z

Current remaining issues to sort out from the list above:

retain Essential: true for ncurses and libncurses6-shlibs
offload terminfo files to a new splitoff
decide on naming for new libN=6 headers: libncurses6 vs libncurses6-dev. libncurses6-dev would allow dropping the Provides field.

The first two would be to somewhat align with Debian's layout if we so desired, but it would slightly increase packaging complexity (making a SplitOff for a new terminfo library and moving some terminfo files to a new SplitOff)

SplitOff naming hasn't come to a final decision. Current naming as submitted continues the scheme we have had for libncurses5-shlibs since 2003.
Options are:

libncurses6-shlibs, libncurses6, Provides::libncurses6-dev (current)
libncurses6-shlibs, libncurses6-dev (I prefer this because it reduces ambiguity)
libncurses6, libncurses6-dev, libncurses{6?}-bin (similar to other distros)

danielj7 · 2019-01-04T12:43:31Z

How is this coming along? Since it's been a year I figured I'd bring it up again. :)

As far as package naming goes, I'd prefer either 1 or 2 but have no strong opinions otherwise. 3 might be what other distos use but is wildly different from the vast majority of fink packages.

BTW, the current upstream version is
https://invisible-mirror.net/archives/ncurses/current/ncurses-6.1-20181229.tgz

nieder · 2019-01-08T12:12:36Z

There was disagreement between the naming of the SplitOffs with no resolution between using the general Fink naming convention and Debian's. If there's consensus on the Debian scheme, I'm OK with that, but that goes against the vast majority of our package naming (only 2 out of ~650 in my installed Fink tree).

nieder · 2020-03-17T11:55:09Z

ncurses 6.2 is out.
SplitOff names are still unchanged from original and match what we currently have for ncurses 5.9:

libncurses6-shlibs (libraries)
libncurses6, Provides::libncurses6-dev (headers)
ncurses (binaries and terminfo)

cooljeanius

Just tested this PR with the -m flag; it appears to work fine (on Big Sur, with Xcode 13, at least). The fact that libncurses6 needs -Wno-error=implicit-function-declaration is a bit worrying, and ideally should be fixed so as to not require that, but that can be handled separately, IMO. Also libncursesw5 prints a lot of -Wunused-command-line-argument, but that's pretty minor.

nieder · 2023-10-10T11:38:03Z

The -Wno-error=implicit-function-declaration is from some upstream autoconf macro. I changed it after the fact to -Werror=implicit-function-declaration and the build finished cleanly w/ no actual patching needed.

Upstream by default turns off Werror=implicit-function-declaration, but for us it's better to turn it on everywhere since it's important for ARM.

nieder added 2 commits January 1, 2018 09:01

Initial commit of ncurses-6 by jwhowarth

2fba6ec

https://sourceforge.net/p/fink/package-submissions/4803/ https://sourceforge.net/p/fink/package-submissions/4804/

Standardize C/R fields

5f42622

nieder added the submissions label Jan 1, 2018

nieder requested review from akhansen and dmacks January 1, 2018 21:45

dmacks reviewed Jan 1, 2018

View reviewed changes

Generate and install .pc files

86bbeaf

nieder added 2 commits March 24, 2018 06:13

ncurses 6.1

ec988be

Improve readability by sorting and spacing multi line fields

64ec8eb

nieder added 5 commits March 24, 2018 16:21

Move wide character support to the main libncurses6 pkg, not a separa…

360e79e

…te library. Kill static libraries. Remove typeof flag that's not needed in 64bit systems.

typo

623f19d

Standardize the flags needed to build and install .pc files

10ba013

Move ncurses man3 files to the BDO SplitOffs

6cb1f87

Unbury the libraries and place straight into %p/lib.

3246ab3

Since this is a new libN, there's no reason to hide them and we prefer to use Fink provided libs over system-libs now.

nieder added 3 commits March 17, 2020 06:47

ncurses 6.2

afd84dc

Edit comment about .pc generation.

3f1c151

typos and formatting

da1b2ea

libncurses6: v6.4

465879a

cooljeanius approved these changes Oct 8, 2023

View reviewed changes

cooljeanius mentioned this pull request Oct 8, 2023

Several fink commands fail with "Failed: not a reference at /opt/sw/lib/perl5/Fink/Services.pm line 2045." fink/fink#259

Closed

nieder added 2 commits October 10, 2023 06:46

ncurses6: turn on the implicit-function error check

9f8bbff

Upstream by default turns off Werror=implicit-function-declaration, but for us it's better to turn it on everywhere since it's important for ARM.

http -> https

25d759a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ncurses-6.0 from tracker #29

ncurses-6.0 from tracker #29

nieder commented Jan 1, 2018

dmacks commented Jan 1, 2018 •

edited

dmacks commented Jan 1, 2018

dmacks Jan 1, 2018 •

edited

dmacks commented Jan 1, 2018

dmacks commented Jan 1, 2018 •

edited

beren12 commented Jan 1, 2018 •

edited

dmacks commented Jan 1, 2018

TheSin- commented Jan 1, 2018

dmacks commented Jan 1, 2018

dmacks commented Jan 1, 2018

nieder commented Jan 2, 2018 •

edited

dmacks commented Jan 2, 2018

dmacks commented Jan 2, 2018

danielj7 commented Jan 6, 2018

dmacks commented Jan 6, 2018

nieder commented Jan 6, 2018

nieder commented Jan 6, 2018 •

edited

beren12 commented Jan 7, 2018 via email

nieder commented Jan 7, 2018

nieder commented Jan 20, 2018

dmacks commented Jan 20, 2018

dmrrsn-fink commented Jan 20, 2018 via email

nieder commented Mar 26, 2018 •

edited by dmacks

danielj7 commented Jan 4, 2019

nieder commented Jan 8, 2019

nieder commented Mar 17, 2020

cooljeanius left a comment •

edited

nieder commented Oct 10, 2023

ncurses-6.0 from tracker #29

Are you sure you want to change the base?

ncurses-6.0 from tracker #29

Conversation

nieder commented Jan 1, 2018

dmacks commented Jan 1, 2018 • edited

dmacks commented Jan 1, 2018

dmacks Jan 1, 2018 • edited

Choose a reason for hiding this comment

dmacks commented Jan 1, 2018

dmacks commented Jan 1, 2018 • edited

beren12 commented Jan 1, 2018 • edited

dmacks commented Jan 1, 2018

TheSin- commented Jan 1, 2018

dmacks commented Jan 1, 2018

dmacks commented Jan 1, 2018

nieder commented Jan 2, 2018 • edited

dmacks commented Jan 2, 2018

dmacks commented Jan 2, 2018

danielj7 commented Jan 6, 2018

dmacks commented Jan 6, 2018

nieder commented Jan 6, 2018

nieder commented Jan 6, 2018 • edited

beren12 commented Jan 7, 2018 via email

nieder commented Jan 7, 2018

nieder commented Jan 20, 2018

dmacks commented Jan 20, 2018

dmrrsn-fink commented Jan 20, 2018 via email

nieder commented Mar 26, 2018 • edited by dmacks

danielj7 commented Jan 4, 2019

nieder commented Jan 8, 2019

nieder commented Mar 17, 2020

cooljeanius left a comment • edited

Choose a reason for hiding this comment

nieder commented Oct 10, 2023

dmacks commented Jan 1, 2018 •

edited

dmacks Jan 1, 2018 •

edited

dmacks commented Jan 1, 2018 •

edited

beren12 commented Jan 1, 2018 •

edited

nieder commented Jan 2, 2018 •

edited

nieder commented Jan 6, 2018 •

edited

nieder commented Mar 26, 2018 •

edited by dmacks

cooljeanius left a comment •

edited