Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should use getBaseUrl instead of getRootUrl in startHistoryJs #109

Closed
tedsteen opened this issue Mar 12, 2013 · 2 comments
Closed

Should use getBaseUrl instead of getRootUrl in startHistoryJs #109

tedsteen opened this issue Mar 12, 2013 · 2 comments

Comments

@tedsteen
Copy link
Contributor

goTo(pager.Href5.history.getState().url.replace(pager.Href5.history.getRootUrl(), ''));
should be
goTo(pager.Href5.history.getState().url.replace(pager.Href5.history.getBaseUrl(), ''));

Otherwise pager will not match the correct url when deployed under other context paths than the root

@finnsson
Copy link
Owner

Good catch. I'll take a look at this on monday. If you send a pull request i'll be able to merge it on monday.

Sent from my iPhone

On Mar 12, 2013, at 16:29, Ted Steen notifications@github.com wrote:

goTo(pager.Href5.history.getState().url.replace(pager.Href5.history.getRootUrl(), ''));
should be
goTo(pager.Href5.history.getState().url.replace(pager.Href5.history.getBaseUrl(), ''));

Otherwise pager will not match the correct url when deployed under other context paths than the root


Reply to this email directly or view it on GitHub.

@tedsteen
Copy link
Contributor Author

Replaced by pull request #110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants