Should use getBaseUrl instead of getRootUrl in startHistoryJs #109

Closed
tedsteen opened this Issue Mar 12, 2013 · 2 comments

Comments

Projects
None yet
2 participants
Contributor

tedsteen commented Mar 12, 2013

goTo(pager.Href5.history.getState().url.replace(pager.Href5.history.getRootUrl(), ''));
should be
goTo(pager.Href5.history.getState().url.replace(pager.Href5.history.getBaseUrl(), ''));

Otherwise pager will not match the correct url when deployed under other context paths than the root

Owner

finnsson commented Mar 12, 2013

Good catch. I'll take a look at this on monday. If you send a pull request i'll be able to merge it on monday.

Sent from my iPhone

On Mar 12, 2013, at 16:29, Ted Steen notifications@github.com wrote:

goTo(pager.Href5.history.getState().url.replace(pager.Href5.history.getRootUrl(), ''));
should be
goTo(pager.Href5.history.getState().url.replace(pager.Href5.history.getBaseUrl(), ''));

Otherwise pager will not match the correct url when deployed under other context paths than the root


Reply to this email directly or view it on GitHub.

@tedsteen tedsteen added a commit to tedsteen/pagerjs that referenced this issue Mar 12, 2013

@tedsteen tedsteen When using historyjs use getBaseUrl() instead of getRootUrl() to hand…
…le other context paths other than root. Fixes #109
24239b3
Contributor

tedsteen commented Mar 12, 2013

Replaced by pull request #110

tedsteen closed this Mar 12, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment