Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'page' binding cannot be used with virtual elements #111

Closed
tedsteen opened this issue Mar 13, 2013 · 3 comments
Closed

'page' binding cannot be used with virtual elements #111

tedsteen opened this issue Mar 13, 2013 · 3 comments

Comments

@tedsteen
Copy link
Contributor

would be nice to be able to do
@tedsteen
Copy link
Contributor Author

In combination with lazy loaded templates and view models that is..

@finnsson
Copy link
Owner

Is it that a lazy loaded template cannot contain virtual elements (as direct children?)? There is probably code like this.element.children() that might get confused by virtual elements. Pagerjs should probably use some helper method from knockout instead.

Sent from my iPhone

On Mar 14, 2013, at 17:24, Ted Steen notifications@github.com wrote:

In combination with lazy loaded templates and view models that is..


Reply to this email directly or view it on GitHub.

@tedsteen
Copy link
Contributor Author

That's not what I meant, but it could be an issue.
What I mean is that it would be nice to do something like
<!-- ko page: {id: 'start', sourceOnShow: 'lazy_load_external_content.html .content'} --><!-- /ko --> so that the lazy_load_external_content.html . content will be the only html added and not an additional <div> as when using <div data-bind="page:...">

@DKhalil DKhalil closed this as completed May 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants