Upgrade to Grunt 0.4.0 #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request. I see that the Travis build is failing and I believe its because grunt changed its syntax from to (grunt travis is that Travis CI is configured to run). You can either add this to the pull request or I'll take care of it later today. Either way thanks. |
|
I just updated the gruntfile - the lint task also changed to jshint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Oscar - this pull request is an upgrade to Grunt 0.4.0. I was trying to look at some other issue and was struggling to get "grunt qunit" to spawn phantomjs on Windows. Node's "spawn" function doesn't work so well on Windows when the thing you want to spawn is a .cmd file, and Grunt 0.4.0 added a workaround for this. (see: gruntjs/grunt#155)