Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme update #1026

Merged
merged 8 commits into from
Jul 19, 2023
Merged

Readme update #1026

merged 8 commits into from
Jul 19, 2023

Conversation

robmoffat
Copy link
Member

No description provided.

@netlify
Copy link

netlify bot commented Jul 18, 2023 •
edited

✅ Deploy Preview for fdc3 canceled.

Name Link
🔨 Latest commit a8ff13a
🔍 Latest deploy log https://app.netlify.com/sites/fdc3/deploys/64b7db9c35bfe80008866be6

@kriswest
Copy link
Contributor

Merge master into this branch to fix semgrep result

@robmoffat robmoffat marked this pull request as ready for review July 18, 2023 10:12
@robmoffat robmoffat requested review from kriswest, rikoe and a team July 18, 2023 10:13
kriswest
kriswest reviewed Jul 18, 2023
View reviewed changes
README.md Show resolved Hide resolved
@kriswest kriswest self-requested a review July 18, 2023 13:10
kriswest
kriswest approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

WIll need an update in the bridging PR (5th part to add to the list). Hence, suggest we merge and I'll deal with it in the bridging PR

@kriswest kriswest linked an issue Jul 18, 2023 that may be closed by this pull request
README update / Introductory materials #750
Closed
@kriswest kriswest added this to the 2.1-release-tasks milestone Jul 19, 2023
@robmoffat
Copy link
Member Author

can I merge this?

@kriswest
Copy link
Contributor

can I merge this?

Seems fine to me - had a poke at cleaning up the milestones just now. Although I thought you were going to replace the mend.io content in the security policy with something on semgrep and CVE scanner?

@robmoffat
Copy link
Member Author

security policy with something on semgrep and CVE scanner?

done

@kriswest
Copy link
Contributor

LGTM to me, I say merge it

@robmoffat robmoffat merged commit 4efe985 into master Jul 19, 2023
11 checks passed
@kriswest kriswest mentioned this pull request Jul 25, 2023
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kriswest kriswest kriswest approved these changes

@rikoe rikoe Awaiting requested review from rikoe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1-release-tasks
Development

Successfully merging this pull request may close these issues.

README update / Introductory materials
2 participants
@robmoffat @kriswest