New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marketing Update #1181
Marketing Update #1181
Conversation
✅ Deploy Preview for fdc3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Added new sections to front page including:
|
let badges = ["/img/community/certified-1.2.png", "/img/community/certified-2.0.png"] | ||
|
||
let publishers = relevant.map(r => r.publisher).filter((x, i, a) => a.indexOf(x) === i).sort() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What sort order does this produce? It seems to be neither alphabetical nor date of test pass(es)...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed it, sorting was case sensitive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robmoffat Lots here to look at!
Could you check the home page on a mobile device, it looks like the logo animation, conformance showcase, training section and some of the headings have issues/are not responsive. You might need to use breakpoints in the CSS or more dynamic sizing to resolve
|
@kriswest @bingenito I think I've fixed this on mobile, as well as the icon issue and the community page buttons |
Obviously, every browser is different and it's impossible to design something that works everywhere, but I was trying to get the initial load to show pretty much just the logo and the "Financial Desktop Connectivity and Collaboration Consortium" bit. And, giving each section of the page (Benefits, Users, Training etc) lots of room to breathe. So, showing the "What Is It?" above the fold is the opposite of what I was trying to achieve! 😁 However, if people don't like a big logo then I'm not opposed to shrinking It a little. |
@robmoffat Logo filling entire initial area by design provides the intent I was missing. Thanks. It becomes an opinion thing ultimately. Would it be worth trying what it can look like with the logo still somewhat large on the left and the what is it on the right (ignoring mobile). It's not a showstopper in any sense but wondering if it is worth trying to get the actual "what" above the fold. I do appreciate having the full FDC3 acronym spelled out higher. |
@robmoffat You might have more luck sizing the I had a quick fiddle in the inspector and this sizes the section perfectly: (although it needs putting on a custom class to not affect other sections + the content of the section then needs flex boxing). |
return (<Layout> | ||
<NewSplashTop /> | ||
<WhatIsIt /> | ||
<Benefits /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each of the carousels have a number at the top so you can see where you're up to. When you click prev/next the number changes
hi @kriswest, Your suggestion actually causes an issue when looking at the screen mobile-size: |
@robmoffat weird that it's overlapping two sections. That's probably not a fundamental problem with sizing the sections (which is what you need to do to fit it to any screen, although content inside needs to size itself based on the section as its container), but some interaction with their sizing or positioning. |
If it wasn't obvious, you need to take the sizing off of the logo and wrap it and typewriter text in a flex box. The typewriter text should display at natural size, while the logo needs to shrink to fit in the remain space(flex-shrink). May be more than you want to fiddle with, but its probably the way to fit it precisely to any screen. The overlap you saw is because the content overflowed outside of the sized section as it wasn't responding to it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@kriswest can we merge this? I have an FDC3 video going out soon and it'd be nice to have this out for that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - lots of work here, thanks @robmoffat
I might go hack on the layout of your front page animation to amuse myself at some point (but I'd better get some other things done for you first ;-) )
Work in progress