Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marketing Update #1181

Merged
merged 26 commits into from Apr 29, 2024
Merged

Marketing Update #1181

merged 26 commits into from Apr 29, 2024

Conversation

robmoffat
Copy link
Member

@robmoffat robmoffat commented Apr 3, 2024

Work in progress

Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for fdc3 ready!

Name Link
🔨 Latest commit 631c7bf
🔍 Latest deploy log https://app.netlify.com/sites/fdc3/deploys/66261afb0066320008eeeb15
😎 Deploy Preview https://deploy-preview-1181--fdc3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kriswest kriswest linked an issue Apr 8, 2024 that may be closed by this pull request
@robmoffat robmoffat changed the title Marketing Update Marketing Update - Do Not Merge Apr 9, 2024
@robmoffat robmoffat marked this pull request as ready for review April 9, 2024 13:54
@robmoffat
Copy link
Member Author

Added new sections to front page including:

  • Animated Logo, explanation of acronym.
  • What Its For ( from README.md, including link to the primer)
  • Benefits ( from README.md and various slide decks)
  • Get involved ( from the get-involved page)
  • Parts of the standard (unchanged)
  • Use Cases (see above comment and https://deploy-preview-1181--fdc3.netlify.app/docs/next/use-cases/uc-1)
  • Training and Certification details (from various slides)
  • Streamlined Conformance results including CTA
  • User Showcase (unchanged, except added CTA)
  • Proper support for dark/light modes

let badges = ["/img/community/certified-1.2.png", "/img/community/certified-2.0.png"]

let publishers = relevant.map(r => r.publisher).filter((x, i, a) => a.indexOf(x) === i).sort()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What sort order does this produce? It seems to be neither alphabetical nor date of test pass(es)...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed it, sorting was case sensitive

Copy link
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robmoffat Lots here to look at!

Could you check the home page on a mobile device, it looks like the logo animation, conformance showcase, training section and some of the headings have issues/are not responsive. You might need to use breakpoints in the CSS or more dynamic sizing to resolve

@robmoffat
Copy link
Member Author

  • TL Logo not visible on light mode
  • Buttons on community page now wrong
  • media selectors don't work on preview

@robmoffat
Copy link
Member Author

@kriswest @bingenito I think I've fixed this on mobile, as well as the icon issue and the community page buttons

@bingenito
Copy link
Member

Should more of the "what is it?" section be visible without scrolling? While my monitor is 2160 vertical resolution I don't have the browser full screen and it is dominated by the large icon and then I have half the what is it.

image

@robmoffat
Copy link
Member Author

@bingenito

Should more of the "what is it?" section be visible without scrolling?

Obviously, every browser is different and it's impossible to design something that works everywhere, but I was trying to get the initial load to show pretty much just the logo and the "Financial Desktop Connectivity and Collaboration Consortium" bit. And, giving each section of the page (Benefits, Users, Training etc) lots of room to breathe. So, showing the "What Is It?" above the fold is the opposite of what I was trying to achieve! 😁

However, if people don't like a big logo then I'm not opposed to shrinking It a little.

@bingenito
Copy link
Member

@robmoffat Logo filling entire initial area by design provides the intent I was missing. Thanks. It becomes an opinion thing ultimately. Would it be worth trying what it can look like with the logo still somewhat large on the left and the what is it on the right (ignoring mobile). It's not a showstopper in any sense but wondering if it is worth trying to get the actual "what" above the fold. I do appreciate having the full FDC3 acronym spelled out higher.

@kriswest
Copy link
Contributor

@robmoffat You might have more luck sizing the

element containing the logo and that text and then using a flexbox inside it to size the logo and text under it (rather than sizing the logo itself directly. Ultimately its the whole
that you want to fit...

I had a quick fiddle in the inspector and this sizes the section perfectly:

image

(although it needs putting on a custom class to not affect other sections + the content of the section then needs flex boxing).

return (<Layout>
<NewSplashTop />
<WhatIsIt />
<Benefits />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that Benefits (Manage The Information Overload) and Parts (The API) sections both have a 1 above them in the output. Did you want each of the sections numbered and it isn't being incremented, or do the numbers for the sections need to be removed?

image
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each of the carousels have a number at the top so you can see where you're up to. When you click prev/next the number changes

@robmoffat
Copy link
Member Author

hi @kriswest,

Your suggestion actually causes an issue when looking at the screen mobile-size:
Screenshot 2024-04-17 at 10 12 56

@kriswest
Copy link
Contributor

@robmoffat weird that it's overlapping two sections. That's probably not a fundamental problem with sizing the sections (which is what you need to do to fit it to any screen, although content inside needs to size itself based on the section as its container), but some interaction with their sizing or positioning.

@kriswest
Copy link
Contributor

If it wasn't obvious, you need to take the sizing off of the logo and wrap it and typewriter text in a flex box. The typewriter text should display at natural size, while the logo needs to shrink to fit in the remain space(flex-shrink). May be more than you want to fiddle with, but its probably the way to fit it precisely to any screen.

The overlap you saw is because the content overflowed outside of the sized section as it wasn't responding to it

@robmoffat robmoffat changed the title Marketing Update - Do Not Merge Marketing Update Apr 19, 2024
@robmoffat robmoffat requested a review from a team April 19, 2024 15:58
Copy link
Contributor

@openfin-johans openfin-johans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@robmoffat robmoffat requested a review from kriswest April 19, 2024 15:59
@robmoffat
Copy link
Member Author

@kriswest can we merge this? I have an FDC3 video going out soon and it'd be nice to have this out for that

Copy link
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - lots of work here, thanks @robmoffat
I might go hack on the layout of your front page animation to amuse myself at some point (but I'd better get some other things done for you first ;-) )

@robmoffat robmoffat merged commit c8c2ba2 into main Apr 29, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Use Cases
4 participants