Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adopt latest FINOS contribution documents #276

Closed
wants to merge 2 commits into from

Conversation

rikoe
Copy link
Contributor

@rikoe rikoe commented Oct 25, 2020

This change adopts the latest CONTRIBUTING.md template from the FINOS project blueprint (here).

Our contribution guidelines was an outstanding issue (#45).

I have also pulled in CONTRIBUTING.standards.md from the blueprint, as described in the FINOS Standards Projects Governance.

Fixes #45.

Pull CONTRIBUTING.md from finos project blueprint
Pull CONTRIBUTING.standards.md from standards project governance

Fixes finos#45
[Code of Conduct]: https://github.com/finos/community/blob/master/governance/Code-of-Conduct.md
[Collaborative Principles]: https://github.com/finos/community/blob/master/governance/Collaborative-Principles.md
[Meeting Procedures]: https://github.com/finos/community/blob/master/governance/Meeting-Procedures.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcleo-d @maoo I had to fix these links to the actual FINOS documents - in the templates in the blueprint they lead to 404s.

You may want to update the template to use the full URLs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY @rikoe ! I've created finos/software-project-blueprint#20 to investigate further.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rikoe and @maoo - I have raised finos/software-project-blueprint#21 that fixes the broken links in FINOS blueprint. @maoo is assigned to review.

CONTRIBUTING.standards.md Outdated Show resolved Hide resolved
@mcleo-d
Copy link
Member

mcleo-d commented Oct 26, 2020

Hi @rikoe

It's been recommended by @mindthegab that we jump on a call before your CONTRIBUTING.md changes are merged into the FDC3 repository.

Please note, the following additions have been added to the FDC3 README.md https://github.com/finos/FDC3#participate-in-the-standard-process to communicate the participate in the standard process.

James.

cc @aitana16

@rikoe
Copy link
Contributor Author

rikoe commented Oct 26, 2020

That's fine @mcleo-d - let me know when suits. We probably won't merge anything until we can discuss at PMC meeting this Friday.

Also related: #275 that updates main readme text. Although I haven't changed the above governance/get involved text, just slightly improved the formatting, like so:

image

@rikoe rikoe closed this Oct 30, 2020
@rikoe rikoe deleted the fix/contribution-guidelines branch April 15, 2021 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contribution Guide
4 participants