Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Valuation schema update due to a misspelling #834

Merged
merged 3 commits into from Oct 25, 2022
Merged

Valuation schema update due to a misspelling #834

merged 3 commits into from Oct 25, 2022

Conversation

mistryvinay
Copy link
Contributor

Resolves issue #833

@mistryvinay mistryvinay added bug Something isn't working context-data FDC3 Context Data Working Group labels Oct 17, 2022
@netlify
Copy link

netlify bot commented Oct 17, 2022 •
edited

✅ Deploy Preview for lambent-kulfi-cf51a7 ready!

Name Link
🔨 Latest commit f30b08e
🔍 Latest deploy log https://app.netlify.com/sites/lambent-kulfi-cf51a7/deploys/6357ec340039260008f8c5a6
😎 Deploy Preview https://deploy-preview-834--lambent-kulfi-cf51a7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mistryvinay mistryvinay linked an issue Oct 17, 2022 that may be closed by this pull request
fdc3.valuation has incorrect COUNTRY_ISCODE member #833
Closed
@mistryvinay mistryvinay mentioned this pull request Oct 17, 2022
Closed
@mistryvinay mistryvinay requested a review from a team October 17, 2022 11:30
@mistryvinay mistryvinay self-assigned this Oct 17, 2022
openfin-johans
openfin-johans approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@openfin-johans openfin-johans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@kriswest
Update valuation.schema.json
f30b08e 
fix typo in 2.0 version of schema
kriswest
kriswest approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a commit to also fix in 2.0 schemas. LGTM

@kriswest kriswest merged commit 5631b9c into master Oct 25, 2022
@kriswest kriswest mentioned this pull request Oct 25, 2022
Closed
32 tasks
@kriswest kriswest deleted the 833-fdc3valuation-has-incorrect-country_iscode branch November 10, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kriswest kriswest kriswest approved these changes

@openfin-johans openfin-johans openfin-johans approved these changes

Assignees

@mistryvinay mistryvinay

Labels
bug Something isn't working context-data FDC3 Context Data Working Group
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fdc3.valuation has incorrect COUNTRY_ISCODE member
3 participants
@mistryvinay @kriswest @openfin-johans