544 Desktop Agent Bridging #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… exchange for getAppMetadata
…rror enumeration and notes on raiseIntentForCOntext handling via findIntentsByContext and raiseIntent
…_bridging-Proposal-mk2
…ktop-Agent_bridging-Proposal-mk2
…_bridging-Proposal-mk2
* new schema structure quicktypeUtils update npm scripts update * PR feedback * cleanup * typos * fix type generation folder * Fixed schema structures * copy schemas to website * package json update * removed defunct file * make sources optional * cleanup * Update schemas/bridging/raiseIntentResultResponse.schema.json Co-authored-by: Kris West <kris@cosaic.io> * cleanup * regenerated types * PR feedback * Fixe meta for requests * Apply suggestions from code review * Regenerating bridging typescript * Apply suggestions from code review * adjust OptionalFeatures and IntentResult schemas --------- Co-authored-by: Kris West <kris@cosaic.io>
kriswest
commented
Jul 26, 2023
kriswest
commented
Jul 26, 2023
kriswest
commented
Jul 26, 2023
kriswest
commented
Jul 26, 2023
kriswest
commented
Jul 26, 2023
kriswest
commented
Jul 26, 2023
kriswest
commented
Jul 26, 2023
kriswest
commented
Jul 26, 2023
kriswest
commented
Jul 26, 2023
kriswest
commented
Jul 26, 2023
Co-authored-by: Hugh Troeger <troeger.hugh@gmail.com>
|
@hughtroeger I believe all your comments are dealt with |
mattjamieson
requested changes
Jul 26, 2023
Co-authored-by: Matt Jamieson <10372+mattjamieson@users.noreply.github.com>
mattjamieson
approved these changes
Jul 26, 2023
hughtroeger
approved these changes
Jul 26, 2023
#80) * Add the app to each reference page mermaid diagram to clarify how message exchanges work * Changing arrow style for FDC3 API calls + adding expect type for promise resolution to mermaid diagrams * fix box in mermaid diagram
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes #861
resolves #453
resolves #544
Implements a new Part in the FDC3 Standard: Desktop Agent Bridging