SDA-4178 Add support for SMS protocol

finos · Jul 13, 2023 · 3d5519a · 3d5519a
1 parent 028292b
commit 3d5519a
Show file tree

Hide file tree

Showing 8 changed files with 248 additions and 120 deletions.
diff --git a/installer/win/WixSharpInstaller/Symphony.cs b/installer/win/WixSharpInstaller/Symphony.cs
@@ -484,6 +484,7 @@ public static ActionResult CleanRegistryCurrentUser(Session session)
                 {
                     key.DeleteSubKeyTree("symphony", false);
                     key.DeleteSubKeyTree("Symphony.tel", false);
+                    key.DeleteSubKeyTree("Symphony.sms", false);
                 }
             }
 

diff --git a/src/app/child-window-handler.ts b/src/app/child-window-handler.ts
@@ -57,7 +57,7 @@ const verifyProtocolForNewUrl = (url: string): boolean => {
     return false;
   }
 
-  const allowedProtocols = ['http:', 'https:', 'mailto:', 'symphony:'];
+  const allowedProtocols = ['http:', 'https:', 'mailto:', 'symphony:', 'sms:'];
   // url parse returns protocol with :
   if (allowedProtocols.includes(parsedUrl.protocol)) {
     logger.info(
@@ -207,7 +207,8 @@ export const handleChildWindow = (webContents: WebContents): void => {
   webContents.on(
     'did-create-window',
     (browserWindow: BrowserWindow, details: DidCreateWindowDetails) => {
-      const newWinOptions = details.options as ICustomBrowserWindowConstructorOpts;
+      const newWinOptions =
+        details.options as ICustomBrowserWindowConstructorOpts;
       const width = newWinOptions.width || DEFAULT_POP_OUT_WIDTH;
       const height = newWinOptions.height || DEFAULT_POP_OUT_HEIGHT;
       const newWinKey = getGuid();

diff --git a/src/app/main-api-handler.ts b/src/app/main-api-handler.ts
@@ -496,8 +496,13 @@ ipcMain.on(
           autoUpdate.checkUpdates();
         }
         break;
-      case apiCmds.registerVoiceServices:
-        voiceHandler.registerSymphonyAsDefaultCallApp();
+      case apiCmds.registerPhoneNumberServices:
+        voiceHandler.registerSymphonyAsDefaultApp(arg.protocols);
+        break;
+      case apiCmds.unregisterPhoneNumberServices:
+        voiceHandler.unregisterSymphonyAsDefaultApp(arg.protocols);
+        break;
+      default:
         break;
     }
   },

diff --git a/src/app/protocol-handler.ts b/src/app/protocol-handler.ts
@@ -11,6 +11,7 @@ import { windowHandler } from './window-handler';
 enum protocol {
   SymphonyProtocol = 'symphony://',
   TelProtocol = 'tel:',
+  SmsProtocol = 'sms:',
 }
 
 class ProtocolHandler {
@@ -87,11 +88,8 @@ class ProtocolHandler {
         `protocol-handler: our protocol request is a valid url ${url}! sending request to SFE for further action!`,
       );
       this.preloadWebContents.send('protocol-action', url);
-    } else if (url?.includes('tel:')) {
-      this.preloadWebContents.send(
-        'phone-number-received',
-        url.split('tel:')[1],
-      );
+    } else if (url?.includes('tel:') || url?.includes('sms:')) {
+      this.preloadWebContents.send('phone-number-received', url);
     }
   }
 
@@ -112,6 +110,11 @@ class ProtocolHandler {
       protocol.TelProtocol,
       false,
     );
+    const smsArgFromArgv = getCommandLineArgs(
+      argv || process.argv,
+      protocol.SmsProtocol,
+      false,
+    );
     if (protocolUriFromArgv) {
       logger.info(
         `protocol-handler: we have a protocol request for the url ${protocolUriFromArgv}!`,
@@ -122,6 +125,11 @@ class ProtocolHandler {
         `protocol-handler: we have a tel request for ${telArgFromArgv}!`,
       );
       this.sendProtocol(telArgFromArgv, isAppAlreadyOpen);
+    } else if (smsArgFromArgv) {
+      logger.info(
+        `protocol-handler: we have an sms request for ${smsArgFromArgv}!`,
+      );
+      this.sendProtocol(smsArgFromArgv, isAppAlreadyOpen);
     }
   }