SDA-4102 SDA-4104 About window client version improvement

finos · Mar 14, 2023 · 423e4cf · 423e4cf
1 parent 8ab1c1a
commit 423e4cf
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/app/window-handler.ts b/src/app/window-handler.ts
@@ -1209,11 +1209,7 @@ export class WindowHandler {
     this.aboutAppWindow.webContents.once('did-finish-load', async () => {
       let client = '';
       if (this.url && this.url.startsWith('https://corporate.symphony.com')) {
-        client = this.url.includes('bff')
-          ? this.url.includes('daily')
-            ? 'Symphony 2.0 - Daily'
-            : 'Symphony 2.0'
-          : 'Symphony Classic';
+        client = this.url.includes('daily') ? '- Daily' : '';
       }
       const ABOUT_SYMPHONY_NAMESPACE = 'AboutSymphony';
       const versionLocalised = i18n.t('Version', ABOUT_SYMPHONY_NAMESPACE)();

diff --git a/src/renderer/components/about-app.tsx b/src/renderer/components/about-app.tsx
@@ -94,12 +94,16 @@ export default class AboutApp extends React.Component<{}, IState> {
     } = this.state;
 
     const appName = productName || 'Symphony';
+    const sfeVersionPrefix = 'sfe-lite-';
     const copyright = `${i18n.t(
       'Copyright',
       ABOUT_SYMPHONY_NAMESPACE,
     )()} \xA9 ${new Date().getFullYear()} ${appName}`;
     const podVersion = `${clientVersion} (${buildNumber})`;
     const sdaVersionBuild = `${sdaVersion} (${sdaBuildNumber})`;
+    const formattedSfeVersion = sfeVersion?.includes(sfeVersionPrefix)
+      ? sfeVersion.split(sfeVersionPrefix)[1]
+      : sfeVersion;
     const symphonySectionItems = [
       {
         key: 'POD:',
@@ -115,7 +119,7 @@ export default class AboutApp extends React.Component<{}, IState> {
       },
       {
         key: `${SFE_CLIENT_TYPE_NAME}:`,
-        value: `${sfeVersion} ${client}`,
+        value: `${formattedSfeVersion} ${client}`,
       },
     ];