RTC-13399 only resolve proxy if passed #1709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nly-resolve-proxy-if-passed
…s://github.com/swasunb/SymphonyElectron into swasunb/RTC-13399-only-resolve-proxy-if-passed
sbenmoussati
approved these changes
Feb 20, 2023
swasunb
added a commit
to swasunb/SymphonyElectron
that referenced
this pull request
Feb 20, 2023
* only add proxy arguments if passed to SDA * tests
sbenmoussati
pushed a commit
that referenced
this pull request
Feb 21, 2023
* only add proxy arguments if passed to SDA * tests
sbenmoussati
pushed a commit
to sbenmoussati/SymphonyElectron
that referenced
this pull request
Mar 28, 2023
* only add proxy arguments if passed to SDA * tests
NguyenTranHoangSym
pushed a commit
to NguyenTranHoangSym/SymphonyElectron
that referenced
this pull request
Sep 5, 2023
* only add proxy arguments if passed to SDA * tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If --proxy-server or --proxy-pac-url is passed as commandline args, then only we should resolve proxy and pass it down as commandline arguments to Cloud9.