SDA-4070 Presence status on macOS #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbenmoussati
commented
Feb 28, 2023
| * | ||
| * @param count {number} | ||
| */ | ||
| public updateSystemTrayPresence = (): void => { |
There was a problem hiding this comment.
Adding sys tray presence (req. for macOS, windows benefits from it)
sbenmoussati
commented
Feb 28, 2023
|
|
||
| // Flags can be read more here https://www.electronjs.org/docs/latest/api/browser-window#winsetthumbarbuttonsbuttons-windows | ||
|
|
||
| export class PresenceStatus { | ||
| private presenceStatus: IStatusBadge = { | ||
| status: EPresenceStatus.AVAILABLE, | ||
| status: EPresenceStatus.NO_PRESENCE, |
There was a problem hiding this comment.
By default, no presence is set. We wait the client to provide current user presence.
sbenmoussati
commented
Feb 28, 2023
| @@ -37,9 +38,19 @@ export class PresenceStatus { | |||
|
|
|||
| public getCurrentTray = () => this.tray.current; | |||
|
|
|||
| public destroyCurrentTray = () => { | |||
There was a problem hiding this comment.
destroying tray icon while closing SDA.
sbenmoussati
commented
Feb 28, 2023
| @@ -71,7 +82,15 @@ export class PresenceStatus { | |||
| place === 'tray' ? 'out-of-office-tray.png' : 'out-of-office.png' | |||
| }`; | |||
| break; | |||
|
|
|||
| case EPresenceStatus.IN_A_MEETING: | |||
There was a problem hiding this comment.
Adding support for meetings
sbenmoussati
commented
Feb 28, 2023
| @@ -455,6 +458,12 @@ export class WindowHandler { | |||
| mainEvents.publish('maximize'); | |||
| } | |||
| this.mainWindow.show(); | |||
| initSysTray(); | |||
| if (isMac) { | |||
There was a problem hiding this comment.
macOS: listening for theme changes (light & dark)
NguyenTranHoangSym
approved these changes
Mar 1, 2023
sbenmoussati
added a commit
to sbenmoussati/SymphonyElectron
that referenced
this pull request
Mar 28, 2023
* SDA-4070 Presence status on macOS * bugfix * SDA-4070 Presence status on macOS * SDA-4070 Presence status on macOS
NguyenTranHoangSym
pushed a commit
to NguyenTranHoangSym/SymphonyElectron
that referenced
this pull request
Sep 5, 2023
* SDA-4070 Presence status on macOS * bugfix * SDA-4070 Presence status on macOS * SDA-4070 Presence status on macOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding presence status capabilities on macOS