Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTC-13903 fix c9 multiple network messages 23.4 #1789

Merged
merged 4 commits into from
Mar 16, 2023
Merged

RTC-13903 fix c9 multiple network messages 23.4 #1789

merged 4 commits into from
Mar 16, 2023

Conversation

baphony
Copy link
Contributor

@baphony baphony commented Mar 16, 2023

Copy link
Contributor

@sbenmoussati sbenmoussati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are too many commits pushed in this PR no?

@baphony
Copy link
Contributor Author

baphony commented Mar 16, 2023

Yes, but the changes are correct, are the commits squashed in one merge commit or all of them merged one by one?

@baphony
Copy link
Contributor Author

baphony commented Mar 16, 2023

image

Looks like it's messing up the history 😬

@baphony
Copy link
Contributor Author

baphony commented Mar 16, 2023

Forget my previous message, looks all good on this repo histo:
image

@baphony
Copy link
Contributor Author

baphony commented Mar 16, 2023

There was the same issue with this PR
https://github.com/finos/SymphonyElectron/pull/1782/commits
But it's clean once it's merged

@sbenmoussati sbenmoussati merged commit 2eb94d5 into finos:23.4.x Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants