-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDA-4113: Add url from CMD #1810
Conversation
src/app/window-handler.ts
Outdated
const defaultUrl = 'my.symphony.com'; | ||
const podUrl = !this.globalConfig.url.includes(defaultUrl) | ||
? this.globalConfig.url | ||
: this.userConfig.url; | ||
const userConfigUrl = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it can be removed
src/app/window-handler.ts
Outdated
const defaultUrl = 'my.symphony.com'; | ||
const podUrl = !this.globalConfig.url.includes(defaultUrl) | ||
? this.globalConfig.url | ||
: this.userConfig.url; | ||
const userConfigUrl = | ||
this.userConfig.url && | ||
this.userConfig.url.indexOf('/login/sso/initsso') > -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same logic should be on podUrl
f24b1d6
to
3438ce1
Compare
src/app/window-handler.ts
Outdated
@@ -549,23 +549,28 @@ export class WindowHandler { | |||
if (this.mainWebContents && !this.mainWebContents.isDestroyed()) { | |||
// Load welcome screen | |||
if (this.shouldShowWelcomeScreen && !this.didShowWelcomeScreen) { | |||
const userConfigUrl = | |||
const defaultUrl = 'my.symphony.com'; | |||
const customUrl = this.userConfig.url.slice( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you need to be safer here, url can be not set if it's a first time launch --> slice of undefined --> error
Also, you could rename it customUserConfigUrl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here I think there is no need to do the check on sso, let's do it once and forall on podUrl
, wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sbenmoussati
Hmm I dont seem to get the idea here. customUserConfigUrl meant to get the config instead.
at PodUrl:
Check if userconfig contains sso
get the value and assign to customUserConfigUrl
3438ce1
to
16bba0e
Compare
16bba0e
to
7382a5e
Compare
Description
POD_URL will now be able to update URL at welcome screen
Related PRs