SDA-4220 (Implement API for call notification) #1891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kiran Niranjan <kiran.niranjan@symphony.com>
NguyenTranHoangSym
changed the title
Signed-off-by: Kiran Niranjan <kiran.niranjan@symphony.com>
Signed-off-by: Kiran Niranjan <kiran.niranjan@symphony.com>
sbenmoussati
approved these changes
Jul 12, 2023
| parseInt(String(y), 10), | ||
| ); | ||
| } catch (err) { | ||
| console.warn( |
There was a problem hiding this comment.
Suggested change
| console.warn( | |
| logger.warn( |
| let containerCssClass = `container ${themeClassName} `; | ||
| containerCssClass += customCssClasses.join(' '); | ||
|
|
||
| const acceptText = acceptButtonText |
There was a problem hiding this comment.
What about giving full flexibility on the wording? --> sent through the API?
Logic could be implemented on client side, giving more flexibility.
There was a problem hiding this comment.
Yes, acceptButtonText if present will be used as the button text else it takes the chat type to construct the text
| @@ -1,10 +1,71 @@ | |||
| <html> | |||
| <head> | |||
| <style> | |||
| body { | |||
Signed-off-by: Kiran Niranjan <kiran.niranjan@symphony.com>
…hange Signed-off-by: Kiran Niranjan <kiran.niranjan@symphony.com>
NguyenTranHoangSym
pushed a commit
to NguyenTranHoangSym/SymphonyElectron
that referenced
this pull request
Sep 5, 2023
* SDA-4420 - Implement API for call notification Signed-off-by: Kiran Niranjan <kiran.niranjan@symphony.com> * SDA-4420 - Add unit tests Signed-off-by: Kiran Niranjan <kiran.niranjan@symphony.com> * SDA-4420 - Fix caller name style Signed-off-by: Kiran Niranjan <kiran.niranjan@symphony.com> * SDA-4420 - Change to logger Signed-off-by: Kiran Niranjan <kiran.niranjan@symphony.com> * SDA-4420 - update call toast position based on notification setting change Signed-off-by: Kiran Niranjan <kiran.niranjan@symphony.com> --------- Signed-off-by: Kiran Niranjan <kiran.niranjan@symphony.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement call notification API
Demo
IM
ROOM
Extreme
Redesigned Demo Page 😀