SDA-4177 Windows tel/sms protocols bugfix + macOS protocols registration delegated to Electron #1895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KiranNiranjan
approved these changes
Jul 17, 2023
NguyenTranHoangSym
pushed a commit
to NguyenTranHoangSym/SymphonyElectron
that referenced
this pull request
Sep 5, 2023
…ion delegated to Electron (finos#1895) * Adding protocol in classes * macOS default protocol apply instantly bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes either tel or sms protocols are not available by default on a Windows machine. This PR will create them by default.
on macOS, we delegate protocol registrations (tel and sms protocols to be handled by our app) to Electron as is relies on LSSetDefaultHandlerForURLScheme function: https://github.com/electron/electron/blob/626f46f75a848cf9641ae40f0c82aa1a81d64e64/shell/browser/browser_mac.mm#L226