-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDA-4182_racing: Add racing condition #1903
SDA-4182_racing: Add racing condition #1903
Conversation
96e221e
to
aec7372
Compare
src/app/registry-handler.ts
Outdated
@@ -15,21 +15,19 @@ export const retrieveWindowsRegistry = async (): Promise<string> => { | |||
if (err) { | |||
logger.info('registry-handler: error occurred. Details: ', err); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logger.info('registry-handler: error occurred. Details: ', err); | |
logger.error('registry-handler: error occurred. Details: ', err); |
} else { | ||
if (channel.type === RegistryValueType.REG_SZ) { | ||
registryLocalStore.setRegistry({ currentChannel: channel.value }); | ||
logger.info( | ||
'registry-handler: value retrieved successfully, send to Registry Store', | ||
); | ||
|
||
return channel.value; | ||
} else { | ||
logger.info( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logger.info( | |
logger.error( |
src/app/auto-update-handler.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO this should be reverted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, auto-update-handler.ts
file changes should be reverted + some minor logging changes
aec7372
to
65176f3
Compare
65176f3
to
ba8bf13
Compare
Description
Getting Registry has a delay. That it wont update the latest value
This PR is intended to fix the issue
Related PRs