Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDA-4275 Persist user config on first time launch and on pod URL update #1942

Merged
merged 1 commit into from
Aug 18, 2023
Merged

SDA-4275 Persist user config on first time launch and on pod URL update #1942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/app/main-api-handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,6 +429,7 @@ ipcMain.on(
url: arg.newPodUrl,
});
}
config.writeUserConfig();
const urlFromCmd = getCommandLineArgs(process.argv, '--url=', false);
const { url: userConfigURL } = config.getUserConfigFields(['url']);
const { url: globalConfigURL } = config.getGlobalConfigFields(['url']);
Expand Down
4 changes: 3 additions & 1 deletion src/app/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,14 +83,16 @@ const startApplication = async () => {
await config.initializeUserConfig();
await config.readUserConfig();
await config.checkFirstTimeLaunch();
if (config.isFirstTimeLaunch()) {
const isFirstTimeLaunch = config.isFirstTimeLaunch();
if (isFirstTimeLaunch) {
logger.info(
`main: This is a first time launch! will update config and handle auto launch`,
);
await config.setUpFirstTimeLaunch();
if (!isLinux) {
await autoLaunchInstance.handleAutoLaunch();
}
config.writeUserConfig();
}
await app.whenReady();
if (oneStart) {
Expand Down
Loading