Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDA-4300 (Fix issues related to call toast notification) #1961

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

KiranNiranjan
Copy link
Member

@KiranNiranjan KiranNiranjan commented Sep 27, 2023

Description

This PR fixes all the below issues
SDA-4300
SDA-4297
SDA-4318
SDA-4298
SDA-4319
SDA-4325
SDA-4298
SDA-4340
SDA-4341
SDA-4337

  • Also fix typings issue with clearTimeout & clearInterval in GitHub actions

Related PRs

https://github.com/SymphonyOSF/SFE-RTC/pull/4826

@KiranNiranjan KiranNiranjan merged commit 80df597 into finos:main Sep 28, 2023
6 checks passed
@KiranNiranjan KiranNiranjan deleted the SDA-4300 branch September 28, 2023 07:08
sbenmoussati pushed a commit to sbenmoussati/SymphonyElectron that referenced this pull request Oct 6, 2023
* SDA-4300 - Fix issues related to call toast notification

* SDA-4300 - Fix timer GitHub action issue
KiranNiranjan added a commit that referenced this pull request Oct 6, 2023
* SDA-4299 - Make primary text inline-block (#1950)

* SDA-4300 (Fix issues related to call toast notification) (#1961)

* SDA-4300 - Fix issues related to call toast notification

* SDA-4300 - Fix timer GitHub action issue

* SDA-4332 - Limit toast notification to prevent overlying of call notification (#1966)

* Removed accept button icon + larger buttons (#1970)

* Removed accept button icon + larger buttons

* Removed default image logic in call notifications

* UT fix

---------

Co-authored-by: Kiran Niranjan <kiran.niranjan@symphony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants