Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDA-4430_4431: Adding final factor to fix About us #2044

Merged
merged 1 commit into from
Dec 29, 2023
Merged

SDA-4430_4431: Adding final factor to fix About us #2044

merged 1 commit into from
Dec 29, 2023

Conversation

NguyenTranHoangSym
Copy link
Contributor

Description

Adding a new behavior into About App

  • Close will only show in case PodUrl is originally matched as it was defined in config file
  • Close will share the same width as cancel
  • Close and Save & Restart will be aligned at 3:7 ratio
  • If user changed the podUrl in under any circumstances it should show save & restart

Related PRs

@sbenmoussati sbenmoussati merged commit 0dc3518 into finos:main Dec 29, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbenmoussati sbenmoussati sbenmoussati approved these changes

Assignees

@NguyenTranHoangSym NguyenTranHoangSym

Labels
24.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NguyenTranHoangSym @sbenmoussati