Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TB] Integrate with FINOS CICD #486

Open
evangk6 opened this issue Aug 17, 2023 · 6 comments
Open

[TB] Integrate with FINOS CICD #486

evangk6 opened this issue Aug 17, 2023 · 6 comments
Assignees
Labels
theme builder app Theme Builder application

Comments

@evangk6
Copy link
Contributor

evangk6 commented Aug 17, 2023

Problem/Concern

One of the later steps of the transition would be to ensure we are making use of the appropriate CICD pipeline provided to us. More information would be required at this time.

Proposed Solution

@evangk6 evangk6 added the theme builder app Theme Builder application label Aug 17, 2023
@aaronreed708
Copy link
Contributor

From Mao:

I used to be a big fan of Travis, but after Idera's acquisition, all our contacts left the company and a series of security issues pushed us to switch to GitHub Actions, which is now our preferred platform; that being said, we do have projects using other tools, like CircleCI and CodeFresh (though they're planning to move to GitHub Actions).

@aaronreed708
Copy link
Contributor

review deploy to Netlify, scans and SDK pushing to NPM.

In previous careers, used Prod branch commits to trigger actions. Any opinions on how to do it now?

Proposal:

  • keep main as prod branch
  • dev to be current working branch for day to day commits
  • merge dev into main to "promote"
    • trigger Netlify deploy in TB repo
      • we should probably publish separately to Netlify for a dev commit
    • trigger NPM publish in SDK repo
    • trigger docker image build and push to DockerHub when this is supported
      • tag Docker image to easily identify what came from prod and what came from dev if we decide to publish images for both

Vote: approved by @smithbk, @brycecurtis, @evangk6, @aaronreed708

@aaronreed708
Copy link
Contributor

aaronreed708 commented Oct 19, 2023

Add Netlify deployment to dev branch also. Ensure Docker image publishing also part of GitHub Actions.

@aaronreed708
Copy link
Contributor

@TheJuanAndOnly99 or @maoo, could one of you please update the Netlify for a11y-theme-builder to deploy for both main and dev branches now? Maybe the dev one could be "dev.a11y-theme-builder.finos.org"?

aaronreed708 added a commit to aaronreed708/a11y-theme-builder that referenced this issue Oct 28, 2023
aaronreed708 added a commit that referenced this issue Oct 28, 2023
#486: update contribution guide to use dev br…
aaronreed708 added a commit to aaronreed708/a11y-theme-builder-sdk that referenced this issue Oct 28, 2023
aaronreed708 added a commit to aaronreed708/a11y-theme-builder-sdk that referenced this issue Oct 28, 2023
aaronreed708 added a commit to aaronreed708/a11y-theme-builder-sdk that referenced this issue Oct 28, 2023
aaronreed708 added a commit to aaronreed708/a11y-theme-builder that referenced this issue Oct 28, 2023
aaronreed708 added a commit that referenced this issue Oct 28, 2023
#486: update contribution guide with slack in…
@maoo
Copy link
Member

maoo commented Oct 30, 2023

Done! https://dev.a11y-theme-builder.finos.org/

@aaronreed708
Copy link
Contributor

Looks like NPM publishing is complete, the switch to dev branch development is complete and the dev deployment is complete. Just need to finish up #481 and then we can close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme builder app Theme Builder application
Projects
Status: In Progress
Development

No branches or pull requests

4 participants