Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hotlink underlining #365

Merged
merged 2 commits into from
May 6, 2023
Merged

Fix hotlink underlining #365

merged 2 commits into from
May 6, 2023

Conversation

aaronreed708
Copy link
Contributor

This fixes hotlinks issues with breadcrumbs, hotlinks and Heros in darkmode, especially with hover.

There appears to still be an issue with the Component->Colors->Hotlinks in dark mode. I will open a separate issue for that.

…on hover. Fixed ColorModeSelector no longer setting background correctly for variants
…component hover for black and white variants
@aaronreed708
Copy link
Contributor Author

Also added code back in for ColorModeSelector that I had mistakenly removed in my previous Hero Component patch

@brycecurtis brycecurtis merged commit c3c614a into main May 6, 2023
2 checks passed
@aaronreed708 aaronreed708 deleted the fix-hotlink-underlining branch May 18, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants