New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discoverfinancial/a11y-theme-builder#391: fix checkboxes component in… #393

Merged

brycecurtis merged 1 commit into main from fix-darkmode-black-checkboxes

May 19, 2023

Contributor

aaronreed708 commented May 18, 2023

… dark mode for black variant


          discoverfinancial/a11y-theme-builder#391: fix checkboxes component in…

532cda1

… dark mode for black variant

aaronreed708 requested a review from brycecurtis

May 18, 2023 17:58

Contributor Author

aaronreed708 commented May 18, 2023

Problem was conflicting rule:

.darkmode .black:not(.breadcrumbs) {
     background: var(--black) !important;
     color: var(--dm-white) !important;
 }

Doesn't make sense for checkboxes or their labels, so I'll tweak this rule to exclude MuiFormControlLabels

brycecurtis merged commit 2fbd47a into main

2 checks passed

aaronreed708 deleted the fix-darkmode-black-checkboxes branch

May 19, 2023 15:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment