Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically Load Fonts #433

Merged
merged 12 commits into from
Aug 2, 2023
Merged

Dynamically Load Fonts #433

merged 12 commits into from
Aug 2, 2023

Conversation

evangk6
Copy link
Contributor

@evangk6 evangk6 commented Jul 24, 2023

Completes the work required for https://github.com/discoverfinancial/a11y-theme-builder/issues/405 and most of https://github.com/discoverfinancial/a11y-theme-builder/issues/264:

  • Fonts are loaded when specified
  • Refactoring of FontWeights.util to be compatible
  • Add a dropdown select of fonts
  • Allow user to use the dropdown or textfield
  • Allow only allowed font weights to be selected

Any visual changes request by Lise will be done as part of issue 264's completion

@evangk6 evangk6 requested a review from brycecurtis July 24, 2023 19:54
@evangk6 evangk6 marked this pull request as draft July 26, 2023 17:50
@evangk6
Copy link
Contributor Author

evangk6 commented Jul 26, 2023

Converted to a draft. Just waiting on font weights.

@evangk6 evangk6 marked this pull request as ready for review August 1, 2023 18:35
@evangk6 evangk6 requested review from brycecurtis and removed request for brycecurtis August 1, 2023 18:36
@evangk6
Copy link
Contributor Author

evangk6 commented Aug 2, 2023

@brycecurtis - fixed conflicts and ready for review

@brycecurtis brycecurtis merged commit 6d3b23a into main Aug 2, 2023
2 checks passed
@evangk6 evangk6 deleted the evangk6-405 branch August 9, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants