Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm publishing updates #708

Merged
merged 5 commits into from
Nov 3, 2023
Merged

npm publishing updates #708

merged 5 commits into from
Nov 3, 2023

Conversation

aaronreed708
Copy link
Contributor

The Theme Builder side of the NPM publishing commit. Please do not merge until the corresponding SDK change is in place.

Copy link

netlify bot commented Nov 2, 2023

Deploy Preview for glistening-gecko-6b417a ready!

Name Link
🔨 Latest commit aed492b
🔍 Latest deploy log https://app.netlify.com/sites/glistening-gecko-6b417a/deploys/6544616c344ca30008ed653c
😎 Deploy Preview https://deploy-preview-708--glistening-gecko-6b417a.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aaronreed708 aaronreed708 changed the title Test npm npm publishing updates Nov 2, 2023
Copy link
Contributor

@smithbk smithbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I assume you've tested this, including the update-sdk.sh script

@aaronreed708
Copy link
Contributor Author

closing and reopening PR to re-trigger checks

@aaronreed708 aaronreed708 reopened this Nov 3, 2023
@aaronreed708
Copy link
Contributor Author

LGTM. I assume you've tested this, including the update-sdk.sh script

Yes, tested both the app and the script on test-npm branch. Will re-test with merge.

@aaronreed708 aaronreed708 merged commit f4cca85 into dev Nov 3, 2023
5 checks passed
@aaronreed708 aaronreed708 deleted the test-npm branch November 3, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants