Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Netlify badge #716

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Conversation

turnalfred
Copy link

@turnalfred turnalfred commented Nov 7, 2023

  • Introduced a netlify badge at the footer of the left navigation bar to acknowledge the service.
  • Indentation and syntax improvements in JSX for better readability and code quality.

Closes #686

Copy link

linux-foundation-easycla bot commented Nov 7, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

netlify bot commented Nov 7, 2023

Deploy Preview for glistening-gecko-6b417a ready!

Name Link
🔨 Latest commit c283ea7
🔍 Latest deploy log https://app.netlify.com/sites/glistening-gecko-6b417a/deploys/654b4309cf885d0008247ff7
😎 Deploy Preview https://deploy-preview-716--glistening-gecko-6b417a.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

- Introduced a netlify badge at the footer of the left navigation bar to acknowledge the service.
- Indentation and syntax improvements in JSX for better readability and code quality.
@turnalfred turnalfred marked this pull request as ready for review November 7, 2023 11:08
@turnalfred turnalfred changed the title Add Netlify badge Closes #686 Add Netlify badge Nov 7, 2023
@turnalfred turnalfred changed the base branch from dev to main November 7, 2023 16:41
@turnalfred turnalfred changed the base branch from main to dev November 7, 2023 16:41
Added Netlify badge to the footer of the left navigation bar across multiple pages as a mark of acknowledgement for the service. This was achieved by creating a new `LeftNavFooter` component and importing it in necessary files. Additionally, minor indentation and syntax adjustments have been made in these files for improved code readability and overall code quality.
The Netlify logo in the LeftNavFooter component has been updated to netlify-light.svg instead of netlify-color-bg.svg. This change makes the logo more visually consistent with the rest of the application's design. The new logo is clearer and easier on the eyes when viewed against the background color of the application's left navigation bar.
@aaronreed708
Copy link
Contributor

Hi @turnalfred, sorry that it took me so long to get back to you on this issue. I finally tried out your changes using the Netlify preview in the PR, and what I'm seeing is that the Netlify badge may scroll out of view if the left column contents are longer than the visible column size. Our designer's goal is to have the badge always visible, regardless of how much content is in the column.

I think where I might have confused you is when I said "fixed position". I didn't actually mean having a position: fixed or position: absolute rule in CSS. You were correct in your observation that in such a case if the column grew then there could be content stuck behind that fixed DIV. What I really meant is that the Netlify badge should always be visible in the bottom left of the browser window no matter how long the column got. BUT that the column contents should be sized such that the content window doesn't extend behind the Netlify badge DIV. I haven't had time to try this, yet, but what I'm thinking of is discussed here: https://stackoverflow.com/questions/43173235/make-a-flexbox-middle-part-scroll-without-the-container-taking-100-of-the-page. So, for example, if the column had a header, menu content, and a footer, that the header and footer would always be visible and the menu content area would size to fill whatever space is left in the column. Does that make sense? Are you ok with that? Or do you see problems with that approach as well? If you see an issue with this approach let me know and we can talk it out. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TB] Add Netlify badge to application
3 participants