Update Linter Changes as discussed in #875 #898
Conversation
Signed-off-by: Abhinav Pandey <abhinav.pandey.met22@itbhu.ac.in>
Signed-off-by: Abhinav Pandey <abhinav.pandey.met22@itbhu.ac.in>
❌ Deploy Preview for glistening-gecko-6b417a failed. Why did it fail? →
|
|
Hmmm. I Just noticed that our Linter Changes DO NOT remove unused variables even though we've utilized importing. Would our script need further debugging and changes? Tagging @aaronreed708 for further views. |
Signed-off-by: Abhinav Pandey <abhinav.pandey.met22@itbhu.ac.in>
Shifted the linter because linter couldn't perform well in root directory Also, Major Development Work has been done within `code/src/ui` directory Signed-off-by: Abhinav Pandey <abhinav.pandey.met22@itbhu.ac.in>
|
All Linting changes applied |
I did some quick googling. It looks like linter can fix unused imports automatically, but I didn't see anything about it fixing unused variables. Just warns about them. |
|
Header rules are failing. I'll rectify the issue as soon as possible. I'm looking more into the issue. Sorry for the delay due to lack of time. |
|
Closing this PR. Will Open a new soon |
Should we take alook in this package ? Looks like this componsates for removing unused variables : |
Fixes #897
This PR introduces Linter changes to our Repository