Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Linter changes #905

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Conversation

Sweetdevil144
Copy link
Contributor

Fixes #897

This PR introduces Linter changes as discussed with @aaronreed708 in #897

Signed-off-by: Abhinav Pandey <abhinav.pandey.met22@itbhu.ac.in>
Copy link

netlify bot commented May 24, 2024

Deploy Preview for glistening-gecko-6b417a failed. Why did it fail? →

Name Link
🔨 Latest commit 8d7a6f1
🔍 Latest deploy log https://app.netlify.com/sites/glistening-gecko-6b417a/deploys/665060e95c08cc0008a9d840

@Sweetdevil144
Copy link
Contributor Author

Should we take alook in this package ? Looks like this componsates for removing unused variables :
https://www.npmjs.com/package/@putout/plugin-remove-unused-variables

Idon't understand why header rules are failing ven when We ignore headers

Signed-off-by: Abhinav Pandey <abhinav.pandey.met22@itbhu.ac.in>
Signed-off-by: Abhinav Pandey <abhinav.pandey.met22@itbhu.ac.in>
@Sweetdevil144
Copy link
Contributor Author

Following are major Error Warnings we are getting :

  • Unused variables and imports
  • any type in TypeScript
  • Duplicate imports

Does anyone else have any idea to fix it?

@aaronreed708
Copy link
Contributor

Does anyone else have any idea to fix it?
I'm guessing that we may have to do it manually other than maybe duplicate imports

@Sweetdevil144
Copy link
Contributor Author

Does anyone else have any idea to fix it?
I'm guessing that we may have to do it manually other than maybe duplicate imports

@aaronreed708 there are 778 instances of such error. Can you checkout the above extension I mentioned? Manually would take too uch time and effort in waste.

@aaronreed708
Copy link
Contributor

I guess that it is worth a shot. Have you tried it, yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants