Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo Permissions Cleanup #177

Closed
eddie-knight opened this issue May 14, 2024 · 47 comments
Closed

Repo Permissions Cleanup #177

eddie-knight opened this issue May 14, 2024 · 47 comments
Assignees

Comments

@eddie-knight
Copy link
Contributor

eddie-knight commented May 14, 2024

Problem

Currently there are a large number of individuals with merge access to the CCC repo, and no clear means for the community to self-manage roles and permissions.

Proposed Solution

Adjust repo permissions to correspond with the community guidelines:

  1. Create a new top-level team with sub-teams: ccc
  • Maintainer role given to all SteerCo members and FINOS point of contact
  1. Create child-teams within ccc:
    • ccc-steerco
      • Contains only steerco members
    • ccc-wg-leads
      • Contains only working group leads
    • ccc-wg-XXX
      • Contains approvers for the respective WG
      • Maintainer role given to the respective WG lead
    • members
      • Contains active community members who may have issues and PRs assigned to them
      • tagging @finos/ccc-members will notify the whole community
    • Example:
      • example-teams
  2. Create a CODEOWNERS file following official project guidance
  • Use the CCC GitHub Teams to assign ownership
  1. Modify branch protection to require approval from code owners
  2. Remove the ccc-maintainers team, as it has been replaced by the above groups (if possible, use this as the starter for ccc/members.
  3. Remove the ccc-participants team, as it was only in use during the private stage of the project last year
@sshiells-scottlogic
Copy link
Contributor

@eddie-knight acknowledged. I have a couple of presentations to prep for today and tomorrow, will hopefully get time to start looking into this towards the end of the week.

@iMichaela
Copy link
Contributor

@sshiells-scottlogic & @eddie-knight - I received an automatic meeting indicating I have been removed from the ccc. Does it mean my support is no longer needed?

@eddie-knight
Copy link
Contributor Author

eddie-knight commented May 16, 2024

Definitely not, @iMichaela! A lot of our recent work has been based on your contributions to the discussion, and your input is always appreciated.

I believe everyone will have gotten a similar message when we changed the groups (as outlined above), though I didn't anticipate that happening.

You're still in the CCC members group:

Screenshot 2024-05-16 at 9 37 30 AM

Thanks for touching base on this!

@rachkim00
Copy link
Contributor

@eddie-knight @robmoffat we also received similar message as @iMichaela raised in the comment and got confused. Also, we saw all CCC meetings being cancelled with the note "All CCC meetings are temporarily cancelled."Together with the meeting cancellation, the notification gave us an impression that CCC project itself is paused/cancelled. It would be helpful for audiences to have context on why we were getting an email that we are being removed from the group (due to the changing being made here obviously) and why all CCC meetings are cancelled.

@eddie-knight
Copy link
Contributor Author

eddie-knight commented May 21, 2024

Thanks @rachkim00, and very sorry for the sudden confusion.

We've added a note in the repo to warn against meeting cancellations like that in the future (#179) and, fortunately, we've now launched the communications working group to address oversights like this!

@rachkim00
Copy link
Contributor

@eddie-knight Thank you much! I don't see any CCC meeting in my calendar yet since the cancellation. Hope there will be new ones scheduled.

@eddie-knight
Copy link
Contributor Author

Yes! We are working with @robmoffat and the Communications WG to determine the next meetings.

We'll notify the CCC mailing list and put the public meetings on the calendar— hopefully before the end of the week.

@iMichaela
Copy link
Contributor

Yes! We are working with @robmoffat and the Communications WG to determine the next meetings.

We'll notify the CCC mailing list and put the public meetings on the calendar— hopefully before the end of the week.

Me either!

@robmoffat
Copy link
Member

@eddie-knight :

Please can you expand on each of these groups with details of the group admin and members, so that I can get @TheJuanAndOnly99 to take a look?

Also, I think we need a PR with the CODEOWNERS file in it.

@robmoffat
Copy link
Member

Also, can we make sure all groups are prefixed CCC so that they are easy to find?

@robmoffat
Copy link
Member

ccc-members should be the top-level group with ccc-steer-co, ccc-wg-leads etc. as child groups.

@eddie-knight
Copy link
Contributor Author

eddie-knight commented May 29, 2024

Thanks @robmoffat & @TheJuanAndOnly99. Notably, we recently learned that admins are only able to manage membership, not child groups.

TODO

@eddie-knight
Copy link
Contributor Author

I'll collaborate with @sshiells-scottlogic to create the CODEOWNERS pull request tomorrow. The goal will be for that file to assign responsibility for everything in the repository to one of the WGs or the SteerCo.

That way each group can determine their own acceptance criteria for their respective areas, so that contributions such as PR #153 aren't blocked by a lack of clarity in the future.

@eddie-knight
Copy link
Contributor Author

@robmoffat @sshiells-scottlogic I think we should have the CODEOWNERS file itself be owned by the FINOS Point of Contact, so that there is foundation oversight on who owns each element in the repo.

The alternative is to have the SteerCo own it.

WDYT?

@sshiells-scottlogic
Copy link
Contributor

sshiells-scottlogic commented May 29, 2024 via email

@robmoffat
Copy link
Member

robmoffat commented May 30, 2024

@i'm just going to jump on this issue to lay out the meetings I'm going to create, their length and cadence:

Meeting Cadence Length Notes On FINOS Calendar When Chair
Steering Committee Quarterly 1 Hour Already Exists Yes 2PM UK Time, Second Tuesday of the quarter FINOS
WG: Community Structure Fortnightly 30 mins Yes 5PM UK, 2ND and 4th Thursday each month
WG: Duplication Reduction Fortnightly 30 mins Yes 5:30PM UK, 2ND and 4th Thursday each month Jared Lambert
WG: Taxonomy Informally Sonali Mendis
WG: Security Every 3 weeks 30 mins * every 3 weeks is hard to schedule with the other meetings, so going fortnightly) Yes 4PM UK, 1st and 3rd Thursday each month Michael Lysaght
WG: Delivery Fortnightly 30 mins Yes 4:30PM UK, 1st and 3rd Thursday each month Damien Burke
WG: Communications / All Hands Fortnightly 1 Hour Propose that this replaces the old All-Hands meeting
and includes updates from all WG Leads
Yes 5PM UK, 1st and 3rd Thursday each month Alex St. Pierre
Working Group Leads / Exec Sponsors Monthly 1 Hour Replacing Strategic Initiative Update Meeting No 15:30 – 16:15 UK Monthly on the fourth Friday FINOS

Hopefully, this works - we've got a lot of meetings going on and I don't want to clash with too many other things in the FINOS calendar that people might want to do to. However, there ARE clashes with Backstage WG, and FDC3 for Web Browsers. I am heavily involved in that second one, so I won't be able to attend the second Delivery meeting of the month.

@jared-lambert, @damienjburks @mlysaght2017 @Alexstpierrework please check your availability.

Once everyone is happy I'll create these and invite the entire mailing list to attend - they can then choose which meetings they'd like to go to.

@smendis-scottlogic
Copy link
Contributor

@i'm just going to jump on this issue to lay out the meetings I'm going to create, their length and cadence:

Meeting Cadence Length Notes On FINOS Calendar When Chair
Steering Committee Quarterly 1 Hour Already Exists Yes 2PM UK Time, Second Tuesday of the quarter FINOS
WG: Community Structure Fortnightly 30 mins Yes 5PM UK, 2ND and 4th Thursday each month
WG: Duplication Reduction Fortnightly 30 mins Yes 5:30PM UK, 2ND and 4th Thursday each month Jared Lambert
WG: Taxonomy Informally Sonali Mendis
WG: Security Every 3 weeks 30 mins * every 3 weeks is hard to schedule with the other meetings, so going fortnightly) Yes 4PM UK, 1st and 3rd Thursday each month Michael Lysaght
WG: Delivery Fortnightly 30 mins Yes 4:30PM UK, 1st and 3rd Thursday each month Damien Burke
WG: Communications / All Hands Fortnightly 1 Hour Propose that this replaces the old All-Hands meeting
and includes updates from all WG Leads Yes 5PM UK, First Thursday each month Alex St. Pierre
Working Group Leads / Exec Sponsors Monthly 1 Hour Replacing Strategic Initiative Update Meeting No 15:30 – 16:15 UK Monthly on the fourth Friday FINOS
Hopefully, this works - we've got a lot of meetings going on and I don't want to clash with too many other things in the FINOS calendar that people might want to do to. However, there ARE clashes with Backstage WG, and FDC3 for Web Browsers. I am heavily involved in that second one, so I won't be able to attend the second Delivery meeting of the month.

@jared-lambert, @damienjburks @mlysaght2017 @Alexstpierrework please check your availability.

Once everyone is happy I'll create these and invite the entire mailing list to attend - they can then choose which meetings they'd like to go to.

@robmoffat Can Taxonomy WG have fortnightly meeting slots as well? I think I misunderstood what is informal when we last talked about it. I would like recurring fortnightly meetings that are not on FINOS calendar. Will that be possible? Thanks!

@iMichaela
Copy link
Contributor

@robmoffat - It looks like WG:Security and WG:Delivery are back-to-back. Is there a vision that members will be involved in more than one WG? Since I do not see a dedicated WG for the conversion of the security information in OSCAL and piloting or guiding the security automation process (for certification purpose), I am assuming the work will start under "Security" WG and continue inner "Delivery" WG . Is there a different vision for the work? Alternatively, "Security" WG can generate OSCAL samples and Delivery will be responsible for the tooling and conversion of the entire information.

@eddie-knight
Copy link
Contributor Author

Is there a vision that members will be involved in more than one WG?

Absolutely. The delineation of responsibilities is to help scope the work commitments and enable granular reviews and approvals as things progress.

I am assuming the work will start under "Security" WG and continue inner "Delivery" WG . Is there a different vision for the work? Alternatively, "Security" WG can generate OSCAL samples and Delivery will be responsible for the tooling and conversion of the entire information.

Should we open a new issue for this question?

We'll need to get guidance on this topic from @damienjburks and @mlysaght2017. Input from @jared-lambert / Duplication Reduction might help as well.

@iMichaela
Copy link
Contributor

Should we open a new issue for this question?

If there is no vision , no guidance, then we will need those and opening an issue might be a simple way of ensuring this is tracked.

@mlysaght2017
Copy link
Contributor

@robmoffat - I think aligning the Security WG with a fortnightly frequency would work better. Otherwise, I'm good.

@mlysaght2017
Copy link
Contributor

@iMichaela @eddie-knight @damienjburks - agree that we need more clarity on where the assessment layer falls.

@iMichaela
Copy link
Contributor

iMichaela commented May 30, 2024

@iMichaela @eddie-knight @damienjburks - agree that we need more clarity on where the assessment layer falls.

@mlysaght2017 - the clarification I requested is going beyond assessment.

  1. I initiated OSCAL samples for the security information we want in digital format. Determining best way of representing the information to support the overall vision and the deliverables is key to success. Such samples can be created by hand by my, Rachel, maybe others, but not by all SME developing logical controls, assessment requirements and tests.

  2. For smooth digitalization of the information the WG(s) members will need:

  • a tool/software that will convert the information into OSCAL as soon as the information is completed/updated, OR
  • an editorial tool the SME developing the logical controls and the assessment requirements can use
  1. a plan for the release of the information (first release, minor updates, patches). Need to think how will the consumers of the information are going to consume it...

  2. a website with guidance or local guidance in GH

@eddie-knight

This comment has been minimized.

@mlysaght2017
Copy link
Contributor

That's great guidance, thanks @iMichaela . I'll create some issues with dependencies Will also expand on the initial example controls we have to have a larger sample to work with.

@iMichaela
Copy link
Contributor

Looks like we already have #139 to discuss the OSCAL topic. It could also be added to the agenda for the upcoming Security and/or Delivery meetings. @iMichaela, you might also apply feedback to #153 if you feel like that approach could be improved.

But #139 was not addressed - was it? I reviewed and approved, from OSCAL perspective, the PR #153

@eddie-knight
Copy link
Contributor Author

I'm not sure- happy to let you and @mlysaght2017 collab to keep things organized for that workstream.

@robmoffat and @TheJuanAndOnly99 please note that there are action items for you in the comments above on the topic of permissions and meetings cleanup

@sshiells-scottlogic
Copy link
Contributor

@i'm just going to jump on this issue to lay out the meetings I'm going to create, their length and cadence:

Meeting Cadence Length Notes On FINOS Calendar When Chair
Steering Committee Quarterly 1 Hour Already Exists Yes 2PM UK Time, Second Tuesday of the quarter FINOS
WG: Community Structure Fortnightly 30 mins Yes 5PM UK, 2ND and 4th Thursday each month
WG: Duplication Reduction Fortnightly 30 mins Yes 5:30PM UK, 2ND and 4th Thursday each month Jared Lambert
WG: Taxonomy Informally Sonali Mendis
WG: Security Every 3 weeks 30 mins * every 3 weeks is hard to schedule with the other meetings, so going fortnightly) Yes 4PM UK, 1st and 3rd Thursday each month Michael Lysaght
WG: Delivery Fortnightly 30 mins Yes 4:30PM UK, 1st and 3rd Thursday each month Damien Burke
WG: Communications / All Hands Fortnightly 1 Hour Propose that this replaces the old All-Hands meeting
and includes updates from all WG Leads Yes 5PM UK, First Thursday each month Alex St. Pierre
Working Group Leads / Exec Sponsors Monthly 1 Hour Replacing Strategic Initiative Update Meeting No 15:30 – 16:15 UK Monthly on the fourth Friday FINOS
Hopefully, this works - we've got a lot of meetings going on and I don't want to clash with too many other things in the FINOS calendar that people might want to do to. However, there ARE clashes with Backstage WG, and FDC3 for Web Browsers. I am heavily involved in that second one, so I won't be able to attend the second Delivery meeting of the month.

@jared-lambert, @damienjburks @mlysaght2017 @Alexstpierrework please check your availability.

Once everyone is happy I'll create these and invite the entire mailing list to attend - they can then choose which meetings they'd like to go to.

@robmoffat I can chair the community structure meetings.

@robmoffat
Copy link
Member

@robmoffat - I think aligning the Security WG with a fortnightly frequency would work better. Otherwise, I'm good.

Sorry if it wasn't clear, that's what I did already @mlysaght2017

@robmoffat
Copy link
Member

@robmoffat I can chair the community structure meetings.

Awesome, thanks @smendis-scottlogic

@robmoffat
Copy link
Member

robmoffat commented May 31, 2024

Ok, here's a revised schedule:

Meeting Cadence Length Notes On FINOS Calendar When Chair
Steering Committee Quarterly 1 Hour Already Exists Yes 2PM UK Time, Second Tuesday of the quarter FINOS
WG: Community Structure Fortnightly 30 mins Yes 5PM UK, 2ND and 4th Thursday each month Stevie Shiells
WG: Duplication Reduction Fortnightly 30 mins Yes 5:30PM UK, 2ND and 4th Thursday each month Jared Lambert
WG: Taxonomy Fortnightly 30 mins Yes 4:30PM UK Time, 2nd and 4th Thursday each month Sonali Mendis
WG: Security Every 3 weeks 30 mins * every 3 weeks is hard to schedule with the other meetings, so going fortnightly) Yes 4PM UK, 1st and 3rd Thursday each month Michael Lysaght
WG: Delivery Fortnightly 30 mins Yes 4:30PM UK, 1st and 3rd Thursday each month Damien Burke
WG: Communications / All Hands Fortnightly 1 Hour Propose that this replaces the old All-Hands meeting
and includes updates from all WG Leads
Yes 5PM UK, 1st and 3rd Thursday each month Alex St. Pierre
Working Group Leads / Exec Sponsors Monthly 1 Hour Replacing Strategic Initiative Update Meeting No 15:30 – 16:15 UK Monthly on the fourth Friday FINOS

And to summarise the meetings on a Thursday, over a month they would look like this:

UK / EST 1st 2nd 3rd 4th
4:00pm / 11:00am SEC SEC
4:30pm / 11:30am DEL TAX DEL TAX
5:00pm / 12:00am Comms CS Comms CS
5:30pm / 12:30am Comms DR Comms DR

If we're all happy with this, I'll work with @TheJuanAndOnly99 and create all this. Note for @TheJuanAndOnly99 I think we're going to need to create a second CCC zoom account and interleave the uses of them so that the meetings can be allowed to overrun and not crash into each other. WDYT?

@sshiells-scottlogic
Copy link
Contributor

@robmoffat I can chair the community structure meetings.

Awesome, thanks @smendis-scottlogic

Hey @robmoffat that was myself (@sshiells-scottlogic) rahter than @smendis-scottlogic that volunteered for that :)

@robmoffat
Copy link
Member

@robmoffat I can chair the community structure meetings.

Awesome, thanks @smendis-scottlogic

Hey @robmoffat that was myself (@sshiells-scottlogic) rahter than @smendis-scottlogic that volunteered for that :)

oops sorry! I'll go back and fix the table...

@smendis-scottlogic
Copy link
Contributor

@robmoffat Can I request Taxonomy meeting to be scheduled from 4:30-5:00 instead of 4:00 to 4:30 so we can participate in community structure call right after the taxonomy call?

@robmoffat
Copy link
Member

@robmoffat Can I request Taxonomy meeting to be scheduled from 4:30-5:00 instead of 4:00 to 4:30 so we can participate in community structure call right after the taxonomy call?

sure - let me update this one more time...

@robmoffat
Copy link
Member

Hi everyone,

Is it ok for @TheJuanAndOnly99 to create these GitHub teams now? Or do we want to wait until CODEOWNERS PR is done?

@eddie-knight
Copy link
Contributor Author

eddie-knight commented Jun 3, 2024 via email

@robmoffat
Copy link
Member

thanks for the steer

@TheJuanAndOnly99
Copy link
Member

@eddie-knight @robmoffat I've created the teams. There are pending invitations for @mlysaght2017, @Alexstpierrework, and @damienjburks.

@eddie-knight
Copy link
Contributor Author

Thanks @TheJuanAndOnly99!

@eddie-knight
Copy link
Contributor Author

@TheJuanAndOnly99 can you please check out #181 and compare it to the GitHub teams? It's still giving an error on a few of the groups.

@eddie-knight
Copy link
Contributor Author

Thanks @TheJuanAndOnly99 — the teams all exist now. Can you help set them all as children of the CCC group?

FINOS Teams CCC Child Teams
Screenshot 2024-06-05 at 8 14 54 AM Screenshot 2024-06-05 at 8 15 06 AM

@TheJuanAndOnly99
Copy link
Member

Hi @eddie-knight I've set the CCC WG Leads team as a child of the CCC team. All the other CCC WG teams were previously set as children of the CCC WG Leads team making them 'grandchildren' of the CCC team. Does this work? A team can only have 1 parent team.

@eddie-knight
Copy link
Contributor Author

I see what you mean. Visually this is great, but we will have an issue if the WG Leads group receives an elevated permission at some point... then every WG member will inherit those elevated permissions.

It'll be easier to manage if they're all siblings within Common Cloud Controls

@TheJuanAndOnly99
Copy link
Member

@eddie-knight I've made them all siblings.

@eddie-knight
Copy link
Contributor Author

Thanks Juan! Closing this issue as complete.

@robmoffat, I believe you have everything needed for the revised meeting schedule... of course feel free to continue discussion here or elsewhere as needed. We should collab through the Comms WG to notify the community of the updated cadence and mail groups.

@Alexstpierrework
Copy link

Alexstpierrework commented Jun 5, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants