Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft Proposal for Threat Catalog and Control Catalog Taxonomy #153
base: main
Are you sure you want to change the base?
Draft Proposal for Threat Catalog and Control Catalog Taxonomy #153
Changes from 18 commits
8eb34e3
7d6012c
0f940ec
4bd0f12
a28a9fe
88451b6
a66d7f7
54ec5f3
c5d8fb3
191a98c
8662419
1af7831
51f5c64
09377cf
681e4b8
64e4335
e6658ed
66e358b
d6296e3
04aa77c
1170a01
e740917
ea20e65
9a9cba2
95d79c3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the
Test
column:In our taxonomy work, @smendis-scottlogic and I proposed keeping taxonomy tests in a parallel gherkin file for each service.
I like the idea of keeping things simple in one place, but I'm not sure how well it reads in this format. Curious to hear feedback on whether
Test
should be included here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the
NIST CF
column:Do we anticipate that any controls will fall outside of the
Protect
category?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an interesting question. On
Detect
, I can see benefit in assessing the CSP's native threat detection capabilities (as well as basic audit logging of specific APIs) for a given service - e.g. data stores exposed outside of given data perimeters - here we'd also have the option of mapping to MITRE ATT&CKData Sources
e.g. for Cloud Storage: https://attack.mitre.org/datasources/DS0010/However...this would naturally be a lot more work...It feels like our priority should be on maturing our thinking on
Protect
with moreProtect
examples within and across the services and continuing to think/experiment onDetect
? Feels like an early decision for steerco too.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally agree that the
Test
values in Gherkin don't read well in that format. We can shift to a separate gherkin file as you suggest.