Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CFI OpenShift on GCP #235

Merged
merged 81 commits into from
Aug 2, 2022
Merged

CFI OpenShift on GCP #235

merged 81 commits into from
Aug 2, 2022

Conversation

AdrianHammond
Copy link
Contributor

Initial contribution for CFI for OpenShift on GCP. This provides documentation, config and code to meet the CFI Service Accelerator for OCP?

@AdrianHammond
initial push to create install and day 2 customisations folders
7616a9a
@AdrianHammond
initial documentation commit
6572f95
@AdrianHammond
initial documentation
75cfd15
@AdrianHammond
additional updates to cluster install and day 2 section. Added htpass…
501c505 
…wd section.
@AdrianHammond
updated readme
26d7ef0
@AdrianHammond
updates to readme
9c36f74
@AdrianHammond
correct typos
19bd762
@AdrianHammond
updated gcp folder README
24d59a6
@AdrianHammond
update accelerator link
355df89
@AdrianHammond
update accelerator link
932fc54
@AdrianHammond
updated intruction.md
0d36a0a
@AdrianHammond
update from git
b5a1a36
@AdrianHammond
Merge branch 'feature/ocp' of https://github.com/AdrianHammond/compli…
fb657ec 
…ant-financial-infrastructure into feature/ocp
@AdrianHammond
rename readme to introduction and update
fdf25f6
@AdrianHammond
updated the cluster installation md file
cfc68c6
@AdrianHammond
updated install-config file
19d973d
@AdrianHammond
rename to gcp_ocp_installation, make minor updates
f0a79db
@AdrianHammond
change to underscores
9f04382
@AdrianHammond
updated htpasswd doc
c0c8fc4
@AdrianHammond
change sample oauth yaml file name
4a8f4f6
@AdrianHammond
change sample name
de53417
@AdrianHammond
fixed typos in introduction
5dac9da
@AdrianHammond
ordered folders for easier reading
0f9d17e
@AdrianHammond
various changes
6cdcbfd
@AdrianHammond
updated intro readme
6af4589
@AdrianHammond
review and update of readme's
52e22e0
@AdrianHammond
adding section to replace API and Router certs
76bfe4e
@AdrianHammond
updated to add customer certs
883c95c
@AdrianHammond
added scan script
473dc1b
@AdrianHammond
updated rescan script
5649b69
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 13, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@AdrianHammond AdrianHammond mentioned this pull request Jul 13, 2022
Closed
@mcleo-d mcleo-d added this to To do in Compliant Financial Infrastructure via automation Jul 15, 2022
@mcleo-d mcleo-d moved this from To do to Ready for Review in Compliant Financial Infrastructure Jul 15, 2022
@mcleo-d mcleo-d added the ready for review Item ready for review by the wider community label Jul 15, 2022
peterrhysthomas
peterrhysthomas approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@peterrhysthomas peterrhysthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with @AdrianHammond, very happy to approve for merging.

Great work!

eddie-knight
eddie-knight approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@eddie-knight eddie-knight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, as this is functional and very well documented with step-by-step instructions.

Still, I'll highlight that this is a highly-complex solution and it may benefit from future work to convert more of this into infrastructure as code (terraform/juju). This can be a follow-up discussion for later.

@abdullahgarcia abdullahgarcia self-requested a review August 2, 2022 09:02
abdullahgarcia
abdullahgarcia approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@abdullahgarcia abdullahgarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great piece of work @AdrianHammond!

@abdullahgarcia
Copy link
Contributor

@AdrianHammond, let's make sure to follow up on @eddie-knight's comment above.

@abdullahgarcia abdullahgarcia merged commit 93ced5c into finos:dev Aug 2, 2022
Compliant Financial Infrastructure automation moved this from Ready for Review to Done Aug 2, 2022
@AdrianHammond
Copy link
Contributor Author

@AdrianHammond, let's make sure to follow up on @eddie-knight's comment above.

Thanks @abdullahgarcia and @eddie-knight - comments noted and will look to address in future PR's

@eddie-knight eddie-knight mentioned this pull request Aug 12, 2022
Closed
@AdrianHammond AdrianHammond mentioned this pull request Aug 26, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterrhysthomas peterrhysthomas peterrhysthomas approved these changes

@abdullahgarcia abdullahgarcia abdullahgarcia approved these changes

@JuozasA JuozasA JuozasA approved these changes

@eddie-knight eddie-knight eddie-knight approved these changes

Assignees

@AdrianHammond AdrianHammond

@peter-thomas-db peter-thomas-db

Labels
ready for review Item ready for review by the wider community
Projects
CFI - Main Project Kanban
Archived in project
Compliant Financial Infrastructure
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@AdrianHammond @abdullahgarcia @peterrhysthomas @JuozasA @eddie-knight @mcleo-d @peter-thomas-db @jhrozek