-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CFI OpenShift on GCP #235
CFI OpenShift on GCP #235
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed with @AdrianHammond, very happy to approve for merging.
Great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, as this is functional and very well documented with step-by-step instructions.
Still, I'll highlight that this is a highly-complex solution and it may benefit from future work to convert more of this into infrastructure as code (terraform/juju). This can be a follow-up discussion for later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great piece of work @AdrianHammond!
@AdrianHammond, let's make sure to follow up on @eddie-knight's comment above. |
Thanks @abdullahgarcia and @eddie-knight - comments noted and will look to address in future PR's |
Initial contribution for CFI for OpenShift on GCP. This provides documentation, config and code to meet the CFI Service Accelerator for OCP?