Terraform IaC for Azure PostgreSQL Single Server with Database and Private Endpoint #98

daniela-g-zheleva-db · 2021-02-12T17:16:05Z

This PR is part of the epic #80. It consists of code to deploy PostgreSQL to Azure, in compliance with the security concerns described in the Service Accelerator Template already in the repo.

The tf code provisions a PostgreSQL Single Server with database and Private Endpoint.

The tf is dependant on there being a virtual network already provisioned in the Azure environment which can be passed in as an input variable.

…from CIBCTO/fdx-cloud-service-certification-working:release/az-postgresql-tf to release/80-az-postgresql-tf Squashed commit of the following: commit 0aa57e2dbc3bee6d556345050c3effee1cd65293 Author: Daniela-G Zheleva <daniela-g.zheleva@db.com> Date: Wed Jan 27 14:46:31 2021 +0000 resource provider commit 8e4db96551f0b7327c3b274d0a569eb362eefdf6 Author: Daniela-G Zheleva <daniela-g.zheleva@db.com> Date: Wed Jan 27 14:45:06 2021 +0000 files dropped out of git when renaming module commit 28d18649f6b35dac0f721788b542dceaf45fe459 Author: Daniela-G Zheleva <daniela-g.zheleva@db.com> Date: Wed Jan 27 14:43:53 2021 +0000 PR changes commit d7a7bc6d8cbb63b20eeaeccecdf85501273cec25 Author: Daniela-G Zheleva <daniela-g.zheleva@db.com> Date: Mon Jan 25 10:33:16 2021 +0000 syntax commit a5368995af0ab0480fc54ae558b8d1f35ea4db31 Author: Daniela-G Zheleva <daniela-g.zheleva@db.com> Date: Mon Jan 25 10:32:30 2021 +0000 add description to vars2 commit e44bf0022f47fd9866d5e5700f20ec98384a692e Author: Daniela-G Zheleva <daniela-g.zheleva@db.com> Date: Mon Jan 25 10:31:05 2021 +0000 add description to vars commit b9ce96a1fed3439f2bda734f7c9ddfb79db3e0a1 Author: Daniela-G Zheleva <daniela-g.zheleva@db.com> Date: Mon Jan 25 10:30:04 2021 +0000 delete non module variables commit 18bbf2c7cec469e317f67e98da8fb5305c58499c Merge: 21ba7c5 44ae054 Author: Daniela-G Zheleva <daniela-g.zheleva@db.com> Date: Mon Jan 25 09:54:39 2021 +0000 Merge branches 'master' and 'release/az-postgresql-tf' of ssh://stash.gto.intranet.db.com:7998/cibcto/fdx-cloud-service-certification-working into release/az-postgresql-tf commit 21ba7c55535c5165653aa858d786e4543878bd2d Author: Daniela-G Zheleva <daniela-g.zheleva@db.com> Date: Fri Jan 15 15:23:44 2021 +0000 readme clarification commit a2ec5615cf65220c754129f31eac5a50fa86b856 Author: Daniela-G Zheleva <daniela-g.zheleva@db.com> Date: Fri Jan 15 14:54:36 2021 +0000 edit readme commit cb760a4cb117c282da23211e97aa4614db942941 Author: Daniela-G Zheleva <daniela-g.zheleva@db.com> Date: Fri Jan 15 14:25:48 2021 +0000 remove .idea commit bfe591fea9fe63ae1fcd440153eca05c7cb25afd Author: Daniela-G Zheleva <daniela-g.zheleva@db.com> Date: Fri Jan 15 14:22:01 2021 +0000 add accidentally deleted files commit 1a921dcbda925264ab0e6fd81c06aae93e41a945 Author: Daniela-G Zheleva <daniela-g.zheleva@db.com> Date: Fri Jan 15 14:19:39 2021 +0000 copy tf over

mcleo-d · 2021-02-12T18:33:39Z

Amazing pull request and contribution 🚀

Thank you @peterrhysthomas, @daniela-g-zheleva-db, @fleadsom and Deutsche Bank ..!

👏 💯 💯 💯

eddie-knight

This is great work. All of my comments are nits or minor suggestions.

Concerning the repo structure- perhaps it would be beneficial to segment the azure tf modules from their implementation logic? A common directory layout I've seen would look something like this:

azure/
  aks/
  postgresql/
  modules/
    aks/
    postgresql/

eddie-knight · 2021-02-16T10:56:59Z

azure/postgresql/terraform/README.md

+| postgres\_resource\_group\_name | Name of resource group to hold postgres | `string` | n/a | yes |
+| postgres\_resource\_group\_tags | Tags to be added to the postgres resource group | `map` | n/a | yes |
+| postgres\_tags | n/a | `map` | n/a | yes |
+| postgres\_version | Version of porstgres | `string` | n/a | yes |


nit: porstgres

eddie-knight · 2021-02-16T10:59:31Z

azure/postgresql/terraform/modules/postgres/postgres.tf

+  server_name         = azurerm_postgresql_server.postgres-server.name
+  value               = "on"
+}
+#Configure postgresql


nit: The spacing between resources here is sometimes 1 space and sometimes 0

eddie-knight · 2021-02-16T11:00:57Z

azure/postgresql/terraform/modules/postgres/variables.tf

+  default = 7
+}
+#Enable geo redundency for Azure postgres
+#Enable geo redundancy for Azure postgres


nit: Duplicate line here

eddie-knight · 2021-02-16T11:06:42Z

azure/postgresql/terraform/modules/postgres/variables.tf

+#Enable geo redundancy for Azure postgres
+variable "geo_redundent_enabled" {
+  type = bool
+  description = "Geo redundent postgres enablement, currently supports only: true"


I'm curious, why does this support only true? I noticed this below as well. Are these intended to be improved upon later- or why have a variable with only one supported value?

eddie-knight · 2021-02-16T11:07:46Z

azure/postgresql/terraform/modules/postgres/variables.tf

+#Password for the database
+variable "database_password" {
+  type = string
+  description = "Password for the database in postgres"


Perhaps use the sensitive value for the credentials variables?
https://learn.hashicorp.com/tutorials/terraform/sensitive-variables#refactor-database-credentials

eddie-knight · 2021-02-16T11:10:39Z

azure/postgresql/terraform/outputs.tf

@@ -0,0 +1,16 @@
+output "server_name" {
+  value = "${var.postgres_name}"


nit:
Perhaps this file doesn't need the interpolation syntax?
Possible improvement: value = var.postgres_name

… from CIBCTO/fdx-cloud-service-certification-working:release/az-postgresql-tf to release/80-az-postgresql-tf Squashed commit of the following: commit fa9baf162be8cbd4945088cf6a15757d0336120c Merge: c7e274c 3281d3e Author: Daniela-G Zheleva <daniela-g.zheleva@db.com> Date: Fri Feb 12 18:03:07 2021 +0000 Merge branches 'release/80-az-postgresql-tf' and 'release/az-postgresql-tf' of ssh://stash.gto.intranet.db.com:7998/cibcto/fdx-cloud-service-certification-working into release/az-postgresql-tf � Conflicts: � azure/postgresql/terraform/README.md commit c7e274c33c3fecaa94b4f468cb67dbcfed8686af Author: Daniela-G Zheleva <daniela-g.zheleva@db.com> Date: Fri Feb 12 17:59:00 2021 +0000 Add missing file and readme comment commit 0aa57e2dbc3bee6d556345050c3effee1cd65293 Author: Daniela-G Zheleva <daniela-g.zheleva@db.com> Date: Wed Jan 27 14:46:31 2021 +0000 resource provider commit 8e4db96551f0b7327c3b274d0a569eb362eefdf6 Author: Daniela-G Zheleva <daniela-g.zheleva@db.com> Date: Wed Jan 27 14:45:06 2021 +0000 files dropped out of git when renaming module commit 28d18649f6b35dac0f721788b542dceaf45fe459 Author: Daniela-G Zheleva <daniela-g.zheleva@db.com> Date: Wed Jan 27 14:43:53 2021 +0000 PR changes commit d7a7bc6d8cbb63b20eeaeccecdf85501273cec25 Author: Daniela-G Zheleva <daniela-g.zheleva@db.com> Date: Mon Jan 25 10:33:16 2021 +0000 syntax commit a5368995af0ab0480fc54ae558b8d1f35ea4db31 Author: Daniela-G Zheleva <daniela-g.zheleva@db.com> Date: Mon Jan 25 10:32:30 2021 +0000 add description to vars2 commit e44bf0022f47fd9866d5e5700f20ec98384a692e Author: Daniela-G Zheleva <daniela-g.zheleva@db.com> Date: Mon Jan 25 10:31:05 2021 +0000 add description to vars commit b9ce96a1fed3439f2bda734f7c9ddfb79db3e0a1 Author: Daniela-G Zheleva <daniela-g.zheleva@db.com> Date: Mon Jan 25 10:30:04 2021 +0000 delete non module variables commit 18bbf2c7cec469e317f67e98da8fb5305c58499c Merge: 21ba7c5 44ae054 Author: Daniela-G Zheleva <daniela-g.zheleva@db.com> Date: Mon Jan 25 09:54:39 2021 +0000 Merge branches 'master' and 'release/az-postgresql-tf' of ssh://stash.gto.intranet.db.com:7998/cibcto/fdx-cloud-service-certification-working into release/az-postgresql-tf commit 21ba7c55535c5165653aa858d786e4543878bd2d Author: Daniela-G Zheleva <daniela-g.zheleva@db.com> Date: Fri Jan 15 15:23:44 2021 +0000 readme clarification commit a2ec5615cf65220c754129f31eac5a50fa86b856 Author: Daniela-G Zheleva <daniela-g.zheleva@db.com> Date: Fri Jan 15 14:54:36 2021 +0000 edit readme commit cb760a4cb117c282da23211e97aa4614db942941 Author: Daniela-G Zheleva <daniela-g.zheleva@db.com> Date: Fri Jan 15 14:25:48 2021 +0000 remove .idea commit bfe591fea9fe63ae1fcd440153eca05c7cb25afd Author: Daniela-G Zheleva <daniela-g.zheleva@db.com> Date: Fri Jan 15 14:22:01 2021 +0000 add accidentally deleted files commit 1a921dcbda925264ab0e6fd81c06aae93e41a945 Author: Daniela-G Zheleva <daniela-g.zheleva@db.com> Date: Fri Jan 15 14:19:39 2021 +0000 copy tf over

daniela-g-zheleva-db · 2021-02-16T16:25:04Z

Thanks @eddie-knight for the comments! I thought I had spotted all the 'porstgres' typos 😄 I will make these changes and push them into the PR as soon as possible.

mcleo-d · 2021-02-17T10:36:53Z

Thanks @eddie-knight and @daniela-g-zheleva-db for collaborating on this PR. It's great to see the Cloud Service Certification project coming together in such an affective way 👏 💯 💯 💯

cc @peterrhysthomas

eddie-knight · 2021-03-25T14:39:16Z

Per our conversation on the call today, I'm of the opinion that the best bet is to apply the suggested changes in a follow-up PR. FYI, whichever maintainer approves/merges this can use the Web UI to correct the .gitignore conflict.

daniela-g-zheleva-db · 2021-03-25T15:03:19Z

Per our conversation on the call today, I'm of the opinion that the best bet is to apply the suggested changes in a follow-up PR. FYI, whichever maintainer approves/merges this can use the Web UI to correct the .gitignore conflict.

Thanks Eddie, @peter-thomas-db Could you please approve this PR and merge. Unfortunately I accidentally deleted the branch internally, and so cannot push changes to this PR. Once it is merged to main I will raise another PR to fix the spelling/spacing issues as pointed out by @eddie-knight

mcleo-d · 2021-03-26T17:45:13Z

👏 💯💯💯

finos-cla-bot bot added the cla-present label Feb 12, 2021

mcleo-d changed the title ~~Merge pull request #9 in CIBCTO/fdx-cloud-service-certification from …~~ Terraform IaC for Azure PostgreSQL Single Server with Database and Private Endpoint Feb 12, 2021

mcleo-d assigned daniela-g-zheleva-db Feb 12, 2021

mcleo-d added azure Items related to Microsoft Azure ready for review Item ready for review by the wider community postgresql Items related to PostgreSQL labels Feb 12, 2021

mcleo-d assigned peterrhysthomas Feb 12, 2021

mcleo-d requested a review from abdullahgarcia February 12, 2021 18:34

mcleo-d added the help wanted Extra attention is needed label Feb 12, 2021

mcleo-d mentioned this pull request Feb 12, 2021

EPIC - PostgreSQL #80

Closed

9 tasks

eddie-knight reviewed Feb 16, 2021

View reviewed changes

mcleo-d mentioned this pull request Feb 17, 2021

Recognising Great Teamwork : @eddie-knight and @daniela-g-zheleva-db of Cloud Service Certification finos/community#103

Closed

mcleo-d added this to To do in Compliant Financial Infrastructure via automation Mar 25, 2021

mcleo-d moved this from To do to Sprint 1 - 25th March (Sprint Start) to 22nd April (Sprint End) in Compliant Financial Infrastructure Mar 25, 2021

Merge branch 'master' into db-contrib/80-az-postgresql-tf

549e431

peterrhysthomas merged commit 21ee6cd into finos:master Mar 25, 2021

Compliant Financial Infrastructure automation moved this from Sprint 1 - 25th March (Sprint Start) to 22nd April (Sprint End) to Done Mar 25, 2021

peterrhysthomas deleted the db-contrib/80-az-postgresql-tf branch March 25, 2021 15:34

mcleo-d mentioned this pull request Apr 1, 2021

8 April 2021 - Cloud Service Certification Meeting - Mid Sprint Meeting #112

Closed

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Terraform IaC for Azure PostgreSQL Single Server with Database and Private Endpoint #98

Terraform IaC for Azure PostgreSQL Single Server with Database and Private Endpoint #98

daniela-g-zheleva-db commented Feb 12, 2021

mcleo-d commented Feb 12, 2021

eddie-knight left a comment

eddie-knight Feb 16, 2021

eddie-knight Feb 16, 2021

eddie-knight Feb 16, 2021

eddie-knight Feb 16, 2021

eddie-knight Feb 16, 2021

eddie-knight Feb 16, 2021

daniela-g-zheleva-db commented Feb 16, 2021

mcleo-d commented Feb 17, 2021

eddie-knight commented Mar 25, 2021

daniela-g-zheleva-db commented Mar 25, 2021 •

edited

mcleo-d commented Mar 26, 2021

		@@ -0,0 +1,16 @@
		output "server_name" {
		value = "${var.postgres_name}"

Terraform IaC for Azure PostgreSQL Single Server with Database and Private Endpoint #98

Terraform IaC for Azure PostgreSQL Single Server with Database and Private Endpoint #98

Conversation

daniela-g-zheleva-db commented Feb 12, 2021

mcleo-d commented Feb 12, 2021

eddie-knight left a comment

Choose a reason for hiding this comment

eddie-knight Feb 16, 2021

Choose a reason for hiding this comment

eddie-knight Feb 16, 2021

Choose a reason for hiding this comment

eddie-knight Feb 16, 2021

Choose a reason for hiding this comment

eddie-knight Feb 16, 2021

Choose a reason for hiding this comment

eddie-knight Feb 16, 2021

Choose a reason for hiding this comment

eddie-knight Feb 16, 2021

Choose a reason for hiding this comment

daniela-g-zheleva-db commented Feb 16, 2021

mcleo-d commented Feb 17, 2021

eddie-knight commented Mar 25, 2021

daniela-g-zheleva-db commented Mar 25, 2021 • edited

mcleo-d commented Mar 26, 2021

daniela-g-zheleva-db commented Mar 25, 2021 •

edited