Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add prepare hook for husky install #196

Merged
merged 2 commits into from Jul 10, 2023

Conversation

vaibssingh
Copy link
Contributor

Fix #188

Verified by running npm run prepare that files in .husky are created from the script as they currently are.

Should we remove the preinstall script too @JamieSlome

@JamieSlome JamieSlome added the bug Something isn't working label Jul 10, 2023
@JamieSlome JamieSlome self-requested a review July 10, 2023 08:19
@JamieSlome
Copy link
Member

@vaibssingh - yes, I think the idea is that the prepare script can replace any form of preinstall script 👍

Once you've removed the script from the package.json, I'll go ahead and run the Actions and merge 💯

@vaibssingh
Copy link
Contributor Author

@JamieSlome Removed the preinstall script :)

Copy link
Member

@JamieSlome JamieSlome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍰

@JamieSlome JamieSlome merged commit 544f021 into finos:main Jul 10, 2023
4 checks passed
coopernetes pushed a commit to coopernetes/git-proxy that referenced this pull request Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate husky install to npm prepare hook
2 participants