Connection equality added for relational database connections #2315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d using equality key based checks Tests added for athena, databricks, snowflake, bigquery and generic
aormerod-gs
approved these changes
Sep 28, 2023
MauricioUyaguari
added a commit
to MauricioUyaguari/legend-engine
that referenced
this pull request
Oct 11, 2023
… - legend using equality key based checks (finos#2315)" This reverts commit 1039d48.
YannanGao-gs
added a commit
to YannanGao-gs/legend-engine
that referenced
this pull request
Oct 11, 2023
… - legend using equality key based checks (finos#2315)" This reverts commit 1039d48.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Improvement
What does this PR do / why is it needed ?
Connection equality is not currently implemented for for relational database connections.
This has been introduced in the store contract using equality key based checks.
Tests added for athena, databricks, snowflake, bigquery and generic. More tests for spanner, redshift etc to follow
Which issue(s) this PR fixes:
Fixes #
Other notes for reviewers:
Does this PR introduce a user-facing change?
No