simplify SDLC and minor code cleanups #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 38093bd The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
akphi
force-pushed
the
proto
branch
3 times, most recently
from
708dba4
to
e70bc7b
Compare
Codecov Report
@@ Coverage Diff @@
## master #1041 +/- ##
==========================================
- Coverage 42.01% 41.93% -0.08%
==========================================
Files 1009 1013 +4
Lines 46131 45978 -153
Branches 10635 10529 -106
==========================================
- Hits 19383 19282 -101
+ Misses 26674 26628 -46
+ Partials 74 68 -6
|
7 tasks
MauricioUyaguari
requested changes
Apr 12, 2022
packages/legend-art/src/components/markdown/MarkdownTextViewer.tsx
Outdated
Show resolved
Hide resolved
| @@ -123,15 +123,14 @@ const setup = async ( | |||
|
|
|||
| test( | |||
| integrationTest( | |||
| 'Service Editor basic registration functionality for PRODUCTION projects', | |||
| 'Service Editor basic registration functionality for projects with versions', | |||
There was a problem hiding this comment.
where are you mocking the sdlc server to provide both with versions and without versions config.
There was a problem hiding this comment.
I'll check again later
packages/legend-studio/src/components/LegendStudioApplication.tsx
Outdated
Show resolved
Hide resolved
akphi
force-pushed
the
proto
branch
3 times, most recently
from
99e8b52
to
d6b90f8
Compare
MauricioUyaguari
approved these changes
Apr 14, 2022
| @@ -123,15 +123,14 @@ const setup = async ( | |||
|
|
|||
| test( | |||
| integrationTest( | |||
| 'Service Editor basic registration functionality for PRODUCTION projects', | |||
| 'Service Editor basic registration functionality for projects with versions', | |||
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sonar)How did you test this change?
New homepage and project creation modal dialog
See the documentation in markdown and where we lay them out
Screen.Recording.2022-04-14.at.10.13.58.AM.mov
Not found page when documentation is provided and not provided
Screen.Recording.2022-04-11.at.4.42.39.PM.mov
Screen.Recording.2022-04-11.at.4.48.12.PM.mov