generated from finos/software-project-blueprint
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize path and element resolution when building graph #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 634b24b The changes in this PR will be included in the next version bump. This PR includes changesets to release 31 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## master #1068 +/- ##
==========================================
+ Coverage 42.29% 42.42% +0.12%
==========================================
Files 1045 1046 +1
Lines 47069 47141 +72
Branches 10726 10745 +19
==========================================
+ Hits 19910 20000 +90
+ Misses 27090 27072 -18
Partials 69 69
|
This was referenced Apr 15, 2022
2e46c2b
to
bfebbbf
Compare
MauricioUyaguari
requested changes
Apr 22, 2022
...s/legend-graph/src/models/protocols/pure/v1/transformation/pureGraph/to/V1_ElementBuilder.ts
Show resolved
Hide resolved
…efaultBlankLambda()
…and renaming element" This reverts commit 6b2da8f.
MauricioUyaguari
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
sectionAutoImports
->autoImports
autoImports
andsectionImports
inV1_GraphBuilderContext
for clearer code.V1_resolvePathsInRawLambda
. We have put control around this behavior to only enable it when processing the main graph.TEMPORARY__keepSectionIndex
toTEMPORARY__preserveSectionIndex
TEMPORARY__disableRawLambdaResolver
as we could useTEMPORARY__preserveSectionIndex
instead.RawInstanceValue
->RawPrimitiveInstanceValue
_$nominalTypeBrand
for models. Just basically keep them for pluginsMappingElementLabel
logic out of@finos/legend-graph
BasicModel.buildPath
AbstractPureGraphManager
V1_deserializePackageableElement
so we properly output error relating to deserialization, alsoV1_PackageableElementSerializer
andV1_PackageableElementTransformer
Jest
config creator to reduce duplicatesgetOrCreatePackage
, a cache mapMap<string, Package>
, pass the cache ininitializeAndIndexElements()
BasicModel.getOwnX()
to throw, create a separate setBasicModel.getOwnNullableX()
.currentSubGraph
: This should be safe to do since we're already doing the duplication checkEmbeddedFlatDataMapping
in the same spirit as Bug: fail to observeEmbeddedRelationalInstanceSetImplementation
#1086parent
field in metamodelnon-observable
andreadonly
jank
caused byobserve_PureModel/observe_Graph
mobx.action()
around methods that create packages likegetOrCreatePackage()
How did you test this change?