Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify metamodels #1153

Merged
merged 6 commits into from
May 10, 2022
Merged

simplify metamodels #1153

merged 6 commits into from
May 10, 2022

Conversation

akphi
Copy link
Contributor

@akphi akphi commented May 10, 2022

Summary

  • Cleanup unnecessary mobx usage in @finos/legend-graph, practically from this moment, the core graph does not use mobx at all; only graph manager does
  • For fields of metamodels that we added to support better graph navigation (i.e. owner, parent, etc.) that are not in the actual metamodels, we should prefix them with, _, e.g. _OWNER, _UUID, _PARENT. Also make these fields readonly
  • Move buildState out of BasicModel and DependencyManager, pass it in as parameter, move them into GraphManagerState
  • Move synthetic enum out of model directories protocols/pure/v1/model, metamodels: these enums are not native to the metamodel, but was added originally for Studio needs
  • Refactor to use reference in: LocalMappingPropertyInfo.localMappingPropertyType
  • Introduced OptionalSetImplementationReference

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

@changeset-bot
Copy link

changeset-bot bot commented May 10, 2022

🦋 Changeset detected

Latest commit: bf902e2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
@finos/legend-application Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-mapping-generation Patch
@finos/legend-graph Major
@finos/legend-query Patch
@finos/legend-server-sdlc Patch
@finos/legend-shared Patch
@finos/legend-studio Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-taxonomy Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-external-language-morphir Patch
@finos/legend-extension-external-store-service Patch
@finos/legend-query-app Patch
@finos/legend-studio-app Patch
@finos/legend-studio-extension-management-toolkit Patch
@finos/legend-studio-extension-query-builder Patch
@finos/legend-taxonomy-app Patch
@finos/legend-graph-extension-collection Patch
@finos/legend-extension-external-format-json-schema Patch
@finos/legend-manual-tests Patch
@finos/legend-art Patch
@finos/legend-model-storage Patch
@finos/legend-server-depot Patch
@finos/legend-tracer-extension-zipkin Patch
@finos/legend-query-deployment Patch
@finos/legend-studio-deployment Patch
@finos/legend-taxonomy-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #1153 (bf902e2) into master (aa992e5) will decrease coverage by 0.02%.
The diff coverage is 47.28%.

@@            Coverage Diff             @@
##           master    #1153      +/-   ##
==========================================
- Coverage   42.49%   42.47%   -0.03%     
==========================================
  Files        1131     1133       +2     
  Lines       50017    50009       -8     
  Branches    11433    11432       -1     
==========================================
- Hits        21257    21241      -16     
- Misses      28689    28698       +9     
+ Partials       71       70       -1     
Impacted Files Coverage Δ
...legend-application/src/stores/LambdaEditorState.ts 6.89% <0.00%> (ø)
...space/src/components/query/DataSpaceQuerySetup.tsx 8.19% <0.00%> (ø)
...s/pure/DSLDataSpace_PureProtocolProcessorPlugin.ts 61.29% <ø> (ø)
...eElements/diagram/DSLDiagram_ClassViewReference.ts 66.66% <ø> (ø)
...sl-diagram/src/stores/studio/DiagramEditorState.ts 11.76% <0.00%> (ø)
...c/components/studio/DSLText_LegendStudioPlugin.tsx 13.63% <0.00%> (ø)
...l-text/src/components/studio/TextElementEditor.tsx 8.00% <0.00%> (+0.30%) ⬆️
...nd-extension-dsl-text/src/helper/DSLText_Helper.ts 0.00% <0.00%> (ø)
...ure/model/packageableElements/text/DSLText_Text.ts 100.00% <ø> (ø)
...t/src/stores/studio/DSLText_GraphModifierHelper.ts 0.00% <0.00%> (ø)
... and 174 more

@MauricioUyaguari
Copy link
Member

@akphi another minor fixes in the making :)

@akphi akphi marked this pull request as ready for review May 10, 2022 20:23
@MauricioUyaguari MauricioUyaguari merged commit 9e3b9b5 into finos:master May 10, 2022
@akphi akphi deleted the reset branch May 10, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-present CLA Signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants