Alert user changing fetch structure resets state #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YannanGao-gs
requested review from
pierredebelen,
akphi and
MauricioUyaguari
as code owners
🦋 Changeset detectedLatest commit: 0228f26 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## master #1383 +/- ##
==========================================
- Coverage 41.88% 41.87% -0.02%
==========================================
Files 1176 1176
Lines 52500 52513 +13
Branches 11943 11948 +5
==========================================
Hits 21989 21989
- Misses 30439 30452 +13
Partials 72 72
|
YannanGao-gs
force-pushed
the
fetchStructure
branch
from
917563c
to
0228f26
Compare
akphi
approved these changes
Aug 5, 2022
akphi
added a commit
to akphi/legend-studio
that referenced
this pull request
Aug 9, 2022
akphi
added a commit
to akphi/legend-studio
that referenced
this pull request
Aug 9, 2022
akphi
added a commit
to akphi/legend-studio
that referenced
this pull request
Aug 11, 2022
xannem
pushed a commit
to xannem/legend-studio
that referenced
this pull request
Aug 11, 2022
akphi
added a commit
to akphi/legend-studio
that referenced
this pull request
Aug 12, 2022
akphi
added a commit
to akphi/legend-studio
that referenced
this pull request
Aug 15, 2022
MauricioUyaguari
pushed a commit
that referenced
this pull request
Aug 16, 2022
* component minor cleanups * minor cleanup post #1383 * temp * minor cleanups * bump dependencies * renamed hashString() to hashValue() * update CHANGELOG * update changesets check * minor fixes * changesets: do not account for private packages without a version * minor fixes * legend-query: add support for light theme * bump dependencies * query builder: default to graph fetch mode * query builder: fix a small problem with switching between fetch modes * query builder: make the projection panel error more subtle * query builder: minor fix for dataspace query editor * cleanup post #1370 * enhance project command search * cleanup and fix problem with DnD overlay * cleanup BlankPanelPlaceholder props * minor cleanup post #1395 (part 1) * query editor: better handle the case when a query is created without a class * query-builder: minor styling fixes * clean up HACKY__ methods in AbstractPureGraphManager * query: add a config to enable/disable beta theme switcher * simplify naming of DND_TYPE * minor fixes * cleanup post #1395 (part 2) * create an use a new component for DnD dropzone placeholder * more cleanups * standardize usage of DnD overlay * improve TS usage for react-dnd * bump dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1380
How did you test this change?
Screen.Recording.2022-08-04.at.5.19.02.PM.mov